Sign upLogin

fuzeman/trakt.py

View on GitHub
Star
trakt/mapper/sync.py

Summary

Maintainability
C
1 day
Test Coverage

Function map_item has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def map_item(cls, client, store, item, media, key=None, parent=None, append=False, **kwargs):
        if item and media in item:
            i_data = item[media]
        else:
            i_data = item
Severity: Minor
Found in trakt/mapper/sync.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function iterate_items has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def iterate_items(cls, client, store, items, func, media=None, **kwargs):
        if store is None:
            store = {}

        if 'movies' not in store:
Severity: Minor
Found in trakt/mapper/sync.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function map_item has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def map_item(cls, client, store, item, media, key=None, parent=None, append=False, **kwargs):
Severity: Major
Found in trakt/mapper/sync.py - About 1 hr to fix

    Function iterate_items has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def iterate_items(cls, client, store, items, func, media=None, **kwargs):
    Severity: Minor
    Found in trakt/mapper/sync.py - About 45 mins to fix

      Function process has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def process(cls, client, store, items, media=None, flat=False, **kwargs):
      Severity: Minor
      Found in trakt/mapper/sync.py - About 45 mins to fix

        Function item has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def item(cls, client, store, item, media=None, **kwargs):
        i_type = item.get('type') or media

        if not i_type:
            raise ValueError('Unknown item type')
        Severity: Minor
        Found in trakt/mapper/sync.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function episode has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def episode(cls, client, store, item, append=False, **kwargs):
        Severity: Minor
        Found in trakt/mapper/sync.py - About 35 mins to fix

          Function item has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def item(cls, client, store, item, media=None, **kwargs):
          Severity: Minor
          Found in trakt/mapper/sync.py - About 35 mins to fix

            Function show has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def show(cls, client, store, item, append=False, **kwargs):
            Severity: Minor
            Found in trakt/mapper/sync.py - About 35 mins to fix

              Function show_season has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def show_season(cls, client, show, season_num, item=None, **kwargs):
              Severity: Minor
              Found in trakt/mapper/sync.py - About 35 mins to fix

                Function show_episode has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def show_episode(cls, client, season, episode_num, item=None, **kwargs):
                Severity: Minor
                Found in trakt/mapper/sync.py - About 35 mins to fix

                  Function map_items has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def map_items(cls, client, store, items, func, **kwargs):
                  Severity: Minor
                  Found in trakt/mapper/sync.py - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                for i_episode in i_season.get('episodes', []):
                episode_num = i_episode.get('number')

                cls.show_episode(client, season, episode_num, i_episode, **kwargs)
                    Severity: Major
                    Found in trakt/mapper/sync.py and 1 other location - About 1 hr to fix
                    trakt/mapper/summary.py on lines 102..105

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 38.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status