Sign upLogin

fy0/slim

View on GitHub
Star
slim/base/_view/abstract_sql_view.py

Summary

Maintainability
C
1 day
Test Coverage

File abstract_sql_view.py has 451 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import logging
from abc import abstractmethod
from typing import Tuple, Union, Dict, Iterable, Type, List, Optional, Mapping
Severity: Minor
Found in slim/base/_view/abstract_sql_view.py - About 6 hrs to fix

    Function _get_list_page_and_size has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def _get_list_page_and_size(self, page, client_size) -> Tuple[int, int]:
        page = page.strip()

        if not page.isdigit():
            raise InvalidParams("`page` is not a number")
    Severity: Minor
    Found in slim/base/_view/abstract_sql_view.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_soft_foreign_key has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_soft_foreign_key(cls, column, table_name, alias=None):
        """
        Add a soft foreign key instead of a real one to avoid constraint problem.
        The `column` should store value of `table_name`'s primary key.
    Severity: Minor
    Found in slim/base/_view/abstract_sql_view.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status