Sign upLogin

gabrielbull/omnimail

View on GitHub
Star

Showing 33 of 33 total issues

Function send has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function send(EmailInterface $email)
    {
        $content = null;
        if ($email->getHtmlBody()) {
            $content = new Content("text/html", $email->getHtmlBody());
Severity: Minor
Found in src/Sendgrid.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function send(EmailInterface $email)
    {
        try {
            $builder = $this->mailgun->MessageBuilder();
Severity: Minor
Found in src/Mailgun.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function send(EmailInterface $email)
    {
        foreach ($email->getTos() as $to) {
            $this->processor->addAddress($to['email'], $to['name']);
        }
Severity: Minor
Found in src/SMTP.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function send(EmailInterface $email)
    {
        try {
            $from = $email->getFrom();
Severity: Minor
Found in src/Mandrill.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function send(EmailInterface $email)
    {
        $content = null;
        if ($email->getHtmlBody()) {
            $content = new Content("text/html", $email->getHtmlBody());
Severity: Major
Found in src/Sendgrid.php - About 3 hrs to fix

    Function send has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function send(EmailInterface $email)
    {
        $m = new SimpleEmailServiceMessage();
        $m->addTo($this->mapEmails($email->getTos()));
        $m->setFrom($this->mapEmail($email->getFrom()));
    Severity: Minor
    Found in src/AmazonSES.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function send(EmailInterface $email)
    {
        try {
            $builder = $this->mailgun->MessageBuilder();
    Severity: Major
    Found in src/Mailgun.php - About 2 hrs to fix

      Method send has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function send(EmailInterface $email)
    {
        try {
            $from = $email->getFrom();
      Severity: Major
      Found in src/Mandrill.php - About 2 hrs to fix

        Method send has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function send(EmailInterface $email)
    {
        try {
            $client = new PostmarkClient($this->serverApiToken);
            $sendResult = $client->sendEmail(
        Severity: Major
        Found in src/Postmark.php - About 2 hrs to fix

          Method send has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function send(EmailInterface $email)
    {
        foreach ($email->getTos() as $to) {
            $this->processor->addAddress($to['email'], $to['name']);
        }
          Severity: Major
          Found in src/SMTP.php - About 2 hrs to fix

            Function send has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                public function send(EmailInterface $email)
    {
        try {
            $client = new PostmarkClient($this->serverApiToken);
            $sendResult = $client->sendEmail(
            Severity: Minor
            Found in src/Postmark.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method send has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function send(EmailInterface $email)
    {
        $m = new SimpleEmailServiceMessage();
        $m->addTo($this->mapEmails($email->getTos()));
        $m->setFrom($this->mapEmail($email->getFrom()));
            Severity: Major
            Found in src/AmazonSES.php - About 2 hrs to fix

              Email has 21 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Email implements EmailInterface
{
    /**
     * @var array
     */
              Severity: Minor
              Found in src/Email.php - About 2 hrs to fix

                Function send has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function send(EmailInterface $email)
    {
        $mailin = new Mailin('https://api.sendinblue.com/v2.0', $this->accessKey);

        $data = [
                Severity: Minor
                Found in src/SendinBlue.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method send has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function send(EmailInterface $email)
    {
        $from = $email->getFrom();

        $body = [
                Severity: Minor
                Found in src/Mailjet.php - About 1 hr to fix

                  Function send has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function send(EmailInterface $email)
    {
        $from = $email->getFrom();

        $body = [
                  Severity: Minor
                  Found in src/Mailjet.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method send has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function send(EmailInterface $email)
    {
        $mailin = new Mailin('https://api.sendinblue.com/v2.0', $this->accessKey);

        $data = [
                  Severity: Minor
                  Found in src/SendinBlue.php - About 1 hr to fix

                    Function mapAttachments has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function mapAttachments(array $attachments = null)
    {
        if (null === $attachments || !is_array($attachments) || !count($attachments)) {
            return null;
        }
                    Severity: Minor
                    Found in src/SendinBlue.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function mapInlineImages has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function mapInlineImages(array $attachments = null)
    {
        if (null === $attachments || !is_array($attachments) || !count($attachments)) {
            return null;
        }
                    Severity: Minor
                    Found in src/SendinBlue.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        private function mapInlineAttachments(array $attachments)
    {
        if (null === $attachments || !is_array($attachments) || !count($attachments)) {
            return null;
        }
                    Severity: Major
                    Found in src/Mailjet.php and 1 other location - About 1 hr to fix
                    src/Mandrill.php on lines 179..197

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 107.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language