gabrielbull/php-ups-api

View on GitHub
src/Entity/Package.php

Summary

Maintainability
C
1 day
Test Coverage

Function __construct has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($attributes = null)
    {
        $this->setPackagingType(new PackagingType(
            isset($attributes->PackagingType) ? $attributes->PackagingType : null)
        );
Severity: Minor
Found in src/Entity/Package.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Package has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class Package implements NodeInterface
{
    const PKG_OVERSIZE1 = '1';
    const PKG_OVERSIZE2 = '2';
    const PKG_LARGE = '4';
Severity: Minor
Found in src/Entity/Package.php - About 3 hrs to fix

    Method __construct has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($attributes = null)
        {
            $this->setPackagingType(new PackagingType(
                isset($attributes->PackagingType) ? $attributes->PackagingType : null)
            );
    Severity: Minor
    Found in src/Entity/Package.php - About 1 hr to fix

      Method toNode has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function toNode(DOMDocument $document = null)
          {
              if (null === $document) {
                  $document = new DOMDocument();
              }
      Severity: Minor
      Found in src/Entity/Package.php - About 1 hr to fix

        Function toNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function toNode(DOMDocument $document = null)
            {
                if (null === $document) {
                    $document = new DOMDocument();
                }
        Severity: Minor
        Found in src/Entity/Package.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status