Sign upLogin

gabrielbull/php-ups-api

View on GitHub
Star
src/Entity/Tradeability/Shipment.php

Summary

Maintainability
B
5 hrs
Test Coverage

Shipment has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class Shipment implements NodeInterface
{
    const TRANSPORT_MODE_AIR = 1;
    const TRANSPORT_MODE_GROUND = 2;
    const TRANSPORT_MODE_RAIL = 3;
Severity: Minor
Found in src/Entity/Tradeability/Shipment.php - About 2 hrs to fix

    Method toNode has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }
    Severity: Minor
    Found in src/Entity/Tradeability/Shipment.php - About 1 hr to fix

      Function toNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }
      Severity: Minor
      Found in src/Entity/Tradeability/Shipment.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status