Sign upLogin

gabrielbull/php-ups-api

View on GitHub
Star
src/Shipping.php

Summary

Maintainability
F
6 days
Test Coverage

Function createConfirmRequest has a Cognitive Complexity of 118 (exceeds 5 allowed). Consider refactoring.
Open

    private function createConfirmRequest(
        $validation,
        Shipment $shipment,
        ShipmentRequestLabelSpecification $labelSpec = null,
        ShipmentRequestReceiptSpecification $receiptSpec = null
Severity: Minor
Found in src/Shipping.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createConfirmRequest has 248 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function createConfirmRequest(
        $validation,
        Shipment $shipment,
        ShipmentRequestLabelSpecification $labelSpec = null,
        ShipmentRequestReceiptSpecification $receiptSpec = null
Severity: Major
Found in src/Shipping.php - About 1 day to fix

    File Shipping.php has 514 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Ups;

use DOMDocument;
    Severity: Major
    Found in src/Shipping.php - About 1 day to fix

      Function recoverLabel has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function recoverLabel($trackingData, $labelSpecification = null, $labelDelivery = null, $translate = null)
    {
        if (is_array($trackingData)) {
            if (!isset($trackingData['value'])) {
                throw new InvalidArgumentException('$trackingData parameter is required to contain `value`.');
      Severity: Minor
      Found in src/Shipping.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createRecoverLabelRequest has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function createRecoverLabelRequest($trackingData, $labelSpecificationOpts = null, $labelDeliveryOpts = null, $translateOpts = null)
    {
        $xml = new DOMDocument();
        $xml->formatOutput = true;
      Severity: Minor
      Found in src/Shipping.php - About 1 hr to fix

        Method compileLabelSpecificationNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function compileLabelSpecificationNode(ShipmentRequestLabelSpecification $labelSpec)
    {
        $xml = new DOMDocument();
        $xml->formatOutput = true;
        Severity: Minor
        Found in src/Shipping.php - About 1 hr to fix

          Function compileLabelSpecificationNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function compileLabelSpecificationNode(ShipmentRequestLabelSpecification $labelSpec)
    {
        $xml = new DOMDocument();
        $xml->formatOutput = true;
          Severity: Minor
          Found in src/Shipping.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method recoverLabel has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function recoverLabel($trackingData, $labelSpecification = null, $labelDelivery = null, $translate = null)
    {
        if (is_array($trackingData)) {
            if (!isset($trackingData['value'])) {
                throw new InvalidArgumentException('$trackingData parameter is required to contain `value`.');
          Severity: Minor
          Found in src/Shipping.php - About 1 hr to fix

            Function createRecoverLabelRequest has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private function createRecoverLabelRequest($trackingData, $labelSpecificationOpts = null, $labelDeliveryOpts = null, $translateOpts = null)
    {
        $xml = new DOMDocument();
        $xml->formatOutput = true;
            Severity: Minor
            Found in src/Shipping.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
            Severity: Minor
            Found in src/Shipping.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if ($rec->getBillShipper()->getCreditCard()->getAddress()) {
                            $ccNode->appendChild($rec->getBillShipper()->getCreditCard()->getAddress()->toNode($xml));
                        }
              Severity: Major
              Found in src/Shipping.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if ($rec->getBillShipper()->getCreditCard()->getSecurityCode()) {
                            $ccNode->appendChild($xml->createElement('SecurityCode', $rec->getBillShipper()->getCreditCard()->getSecurityCode()));
                        }
                Severity: Major
                Found in src/Shipping.php - About 45 mins to fix

                  Function createVoidRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function createVoidRequest($shipmentData)
    {
        $xml = new DOMDocument();
        $xml->formatOutput = true;
                  Severity: Minor
                  Found in src/Shipping.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 8 locations. Consider refactoring.
                  Open

                      public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
    {
        if (null !== $request) {
            $this->setRequest($request);
        }
                  Severity: Major
                  Found in src/Shipping.php and 7 other locations - About 1 hr to fix
                  src/AddressValidation.php on lines 69..81
                  src/Locator.php on lines 40..46
                  src/QuantumView.php on lines 62..68
                  src/SimpleAddressValidation.php on lines 45..57
                  src/TimeInTransit.php on lines 31..37
                  src/Tracking.php on lines 80..86
                  src/Tradeability.php on lines 49..61

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 107.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status