Sign upLogin

gabrielbull/react-aim

View on GitHub
Star

Showing 58 of 58 total issues

Function aiming has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

export default function aiming(e, mousePosition, prevMousePosition, target, alreadyAiming) {
Severity: Minor
Found in src/aim.js - About 35 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (!first) positions.push({ x: target.left + left, y: target.top + target.height + top });
    Severity: Minor
    Found in src/corners.js and 1 other location - About 35 mins to fix
    src/corners.js on lines 81..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (!first) positions.push({ x: target.left + target.width + left, y: target.top + top });
    Severity: Minor
    Found in src/corners.js and 1 other location - About 35 mins to fix
    src/corners.js on lines 66..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (first) positions.push({ x: target.left + target.width + left, y: target.top + top });
    Severity: Minor
    Found in src/corners.js and 1 other location - About 35 mins to fix
    src/corners.js on lines 68..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      content: {
    background: 'black',
    color: 'white',
    height: '22px',
    lineHeight: '22px',
    Severity: Minor
    Found in examples/tooltip/target.js and 1 other location - About 35 mins to fix
    examples/menu/submenu.js on lines 5..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (first) positions.push({ x: target.left + left, y: target.top + target.height + top });
    Severity: Minor
    Found in src/corners.js and 1 other location - About 35 mins to fix
    src/corners.js on lines 83..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const style = {
  position: 'absolute',
  top: '0px',
  left: '100%',
  background: '#eee',
    Severity: Minor
    Found in examples/menu/submenu.js and 1 other location - About 35 mins to fix
    examples/tooltip/target.js on lines 10..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

      if (hor === 0 && ver === 0) return [];
    Severity: Major
    Found in src/corners.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        else if (corners[0] === 'bottom-right' && corners[1] === 'top-left') return 'bottom-left';
      Severity: Major
      Found in src/aim.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          else if (corners[0] === 'top-right' && corners[1] === 'bottom-left') return 'bottom-right';
        Severity: Major
        Found in src/aim.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            else if (corners[0] === 'bottom-left' && corners[1] === 'top-left') return 'left';
          Severity: Major
          Found in src/aim.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (hor === 1 && ver === -1) return ['bottom-right', 'top-left'];
            Severity: Major
            Found in src/corners.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                if (hor === 1 && ver === 0) return ['bottom-left', 'top-left'];
              Severity: Major
              Found in src/corners.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  if (hor === 0 && ver === 1) return ['top-left', 'top-right'];
                Severity: Major
                Found in src/corners.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    else if (corners[0] === 'bottom-right' && corners[1] === 'bottom-left') return 'bottom';
                  Severity: Major
                  Found in src/aim.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      if (hor === 1 && ver === 1) return ['bottom-left', 'top-right'];
                    Severity: Major
                    Found in src/corners.js - About 30 mins to fix

                      Function drawBoundaries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        drawBoundaries(e, svg, rect) {
    const colors = ['blue', 'red', 'red', 'red', 'red'];
    const boundaries = getBoundaries(corners(e, rect), e, rect);
    let lastIndex = -1;
    for (let i = 0, len = boundaries.length; i < len; ++i) {
                      Severity: Minor
                      Found in examples/zone/zone.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function aimStopped has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        aimStopped() {
    if (this.lastEnterRequest) {
      if (this.mouseOver({ pageX: this.mousePosition.x, pageY: this.mousePosition.y }, this.lastEnterRequest)) {
        const enterSource = this.lastEnterRequest;
        this.requestMouseEnter(enterSource)
                      Severity: Minor
                      Found in src/monitor.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language