Sign upLogin

gabynaiman/rasti-db

View on GitHub
Star

Showing 12 of 12 total issues

Class Collection has 42 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Collection

      QUERY_METHODS = Query.public_instance_methods - Object.public_instance_methods

      class << self
Severity: Minor
Found in lib/rasti/db/collection.rb - About 5 hrs to fix

    Class Query has 37 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Query

      DATASET_CHAINED_METHODS = [:where, :exclude, :or, :order, :reverse_order, :limit, :offset].freeze

      include Enumerable
    Severity: Minor
    Found in lib/rasti/db/query.rb - About 4 hrs to fix

      Method fetch_graph has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

              def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
          pks = rows.map { |row| row[source_collection_class.primary_key] }
          
          if target_collection_class.data_source_name == relation_data_source_name
            target_data_source = environment.data_source_of target_collection_class
      Severity: Minor
      Found in lib/rasti/db/relations/many_to_many.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module DB
    module TypeConverters
      module PostgresTypes
        class JSONB
          class << self
      Severity: Major
      Found in lib/rasti/db/type_converters/postgres_types/jsonb.rb and 1 other location - About 1 hr to fix
      lib/rasti/db/type_converters/postgres_types/json.rb on lines 2..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module DB
    module TypeConverters
      module PostgresTypes
        class JSON
          class << self
      Severity: Major
      Found in lib/rasti/db/type_converters/postgres_types/json.rb and 1 other location - About 1 hr to fix
      lib/rasti/db/type_converters/postgres_types/jsonb.rb on lines 2..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method fetch_graph has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
          pks = rows.map { |row| row[source_collection_class.primary_key] }
          
          if target_collection_class.data_source_name == relation_data_source_name
            target_data_source = environment.data_source_of target_collection_class
      Severity: Minor
      Found in lib/rasti/db/relations/many_to_many.rb - About 1 hr to fix

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def initialize(environment, collection_class, relations=[], selected_attributes={}, excluded_attributes={}, queries={})
        Severity: Minor
        Found in lib/rasti/db/relations/graph.rb - About 45 mins to fix

          Method fetch_graph has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
          Severity: Minor
          Found in lib/rasti/db/relations/many_to_one.rb - About 45 mins to fix

            Method fetch_graph has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
            Severity: Minor
            Found in lib/rasti/db/relations/one_to_many.rb - About 45 mins to fix

              Method fetch_graph has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
              Severity: Minor
              Found in lib/rasti/db/relations/many_to_many.rb - About 45 mins to fix

                Method fetch_graph has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                        def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
          pks = rows.map { |row| row[source_collection_class.primary_key] }.uniq

          target_collection = target_collection_class.new environment
                Severity: Minor
                Found in lib/rasti/db/relations/one_to_many.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method fetch_graph has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                        def fetch_graph(environment, rows, selected_attributes=nil, excluded_attributes=nil, queries=nil, relations_graph=nil)
          fks = rows.map { |row| row[foreign_key] }.uniq

          target_collection = target_collection_class.new environment
                Severity: Minor
                Found in lib/rasti/db/relations/many_to_one.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language