Sign upLogin

gabynaiman/restruct

View on GitHub
Star

Showing 10 of 10 total issues

Class Array has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Array < Structure

    include Enumerable
    extend Forwardable
Severity: Minor
Found in lib/restruct/array.rb - About 3 hrs to fix

    Method new has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.new(type)
      Class.new Structure do

        include Enumerable
    Severity: Major
    Found in lib/restruct/nested_hash.rb - About 3 hrs to fix

      Class Hash has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Hash < Structure

    include Enumerable
    extend Forwardable
      Severity: Minor
      Found in lib/restruct/hash.rb - About 2 hrs to fix

        Class Set has 21 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Set < Structure

    include Enumerable
    extend Forwardable
        Severity: Minor
        Found in lib/restruct/set.rb - About 2 hrs to fix

          Method batch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def batch
      incr_nesting
      begin
        result = yield
      ensure
          Severity: Minor
          Found in lib/restruct/connection.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method [] has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def [](*args)
      if args.count == 1
        if args[0].is_a? Integer
          at args[0].to_i
        elsif args[0].is_a? Range
          Severity: Minor
          Found in lib/restruct/array.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def fetch(key, default=nil, &block)
      if key? key
        self[key]
      else
        raise KeyError, "key not found: #{key}" if default.nil? && block.nil?
          Severity: Minor
          Found in lib/restruct/hash.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def fetch(index, default=nil, &block)
      validate_index_type! index

      if index < size
        at index
          Severity: Minor
          Found in lib/restruct/array.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  def keys
          sections = id.sections.count + 1
          connection.call('KEYS', id['*']).map do |k| 
            Id.new(k).sections.take(sections).last
          Severity: Minor
          Found in lib/restruct/nested_hash.rb and 1 other location - About 15 mins to fix
          lib/restruct/cache.rb on lines 18..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def keys
      sections = id.sections.count + 1
      connection.call('KEYS', id['*']).map do |k| 
        Id.new(k).sections.take(sections).last
          Severity: Minor
          Found in lib/restruct/cache.rb and 1 other location - About 15 mins to fix
          lib/restruct/nested_hash.rb on lines 40..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language