Sign upLogin

gadael/gadael

View on GitHub
Star

Showing 761 of 761 total issues

Function saveAbsenceDistribution has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function saveAbsenceDistribution(service, user, params, collection) {


    if (params.absence.distribution === undefined || params.absence.distribution.length === 0) {
        return Promise.reject(new Error('Right distribution is mandatory to save an absence request'));
Severity: Minor
Found in api/services/user/requests/saveAbsence.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createElement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function createElement(service, user, elem, collection, setElemProperties)
{

    if (undefined === elem.right) {
        throw new Error('element must contain a right property');
Severity: Minor
Found in api/services/user/requests/saveAbsence.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isDbNameValid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    isDbNameValid: function isDbNameValid(app, dbName, callback) {


        if (!dbName.match(/[a-z0-9]+/gi) || dbName.length <= 2 || dbName.length > 100)
        {
Severity: Minor
Found in api/Company.api.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

exports = module.exports = function(services, app) {

    let service = new services.list(app);

    const gt = app.utility.gettext;
Severity: Minor
Found in api/services/user/googlecalendars/list.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            renewal: {                                      // open period for the recovery right
                id: { type: mongoose.Schema.Types.ObjectId, ref: 'RightRenewal' },
                start: Date,
                finish: Date
            }
Severity: Minor
Found in schema/Request_WorkperiodRecover.js and 1 other location - About 35 mins to fix
schema/OvertimeSettlement.js on lines 17..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            renewal: {                                      // open period for the recovery right
                id: { type: mongoose.Schema.Types.ObjectId, ref: 'RightRenewal' },
                start: Date,
                finish: Date
            }
Severity: Minor
Found in schema/OvertimeSettlement.js and 1 other location - About 35 mins to fix
schema/Request_WorkperiodRecover.js on lines 17..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.lunch.to && end > this.lunch.to) {
            end = this.lunch.to;
        }
Severity: Minor
Found in schema/User_Account.js and 1 other location - About 35 mins to fix
schema/User_Account.js on lines 1135..1137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.lunch.from && start < this.lunch.from) {
            start = this.lunch.from;
        }
Severity: Minor
Found in schema/User_Account.js and 1 other location - About 35 mins to fix
schema/User_Account.js on lines 1142..1144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

                    return 'has-warning';
Severity: Major
Found in public/js/services/absence-edit.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return {
                    created: 'accepted',
                    deleted: null
                };
    Severity: Major
    Found in schema/Request.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return Promise.reject('Unexpected consumption type '+right.consumption);
      Severity: Major
      Found in schema/Right.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return 'has-success';
        Severity: Major
        Found in public/js/services/absence-edit.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return elem.getLength();
          Severity: Major
          Found in schema/Right.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return null;
            Severity: Major
            Found in schema/Right.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return service.error(gt.gettext('either departments or collections must contain items'));
              Severity: Major
              Found in api/services/admin/compulsoryleaves/save.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return false;
                Severity: Major
                Found in modules/apputil.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return true;
                  Severity: Major
                  Found in modules/testoverlap.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return true;
                    Severity: Major
                    Found in modules/apputil.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return Promise.reject(new Error('Wrong parameter type for user or account'));
                      Severity: Major
                      Found in api/services/user/accountbeneficiaries/list.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return true;
                        Severity: Major
                        Found in api/services/user/calendarevents/list.js - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language