Sign upLogin

gadzorg/GorgEngine

View on GitHub
Star

Showing 11 of 11 total issues

Method change has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def change


    # You HAVE TO edit this file to avoid conflict with your current migrations
    # For each table and for each column : check if exist in your current project, and comment the line if needed.
Severity: Minor
Found in lib/generators/templates/migrations/init_gorg_engine.rb - About 1 hr to fix

    Method update_from_gram has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def update_from_gram
    self.synced_with_gram = false
    if self.syncable?
      begin
        gram_data= GramV2Client::Account.find(self.uuid)
    Severity: Minor
    Found in app/models/user.rb - About 1 hr to fix

      Method sync_with_gram has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def sync_with_gram
    authorize! :sync, @user
    respond_to do |format|
      if @user.syncable? && ( @user.next_sync_allowed_at <= Time.now)
        if @user.update_from_gram
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_from_gram has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_from_gram
    self.synced_with_gram = false
    if self.syncable?
      begin
        gram_data= GramV2Client::Account.find(self.uuid)
      Severity: Minor
      Found in app/models/user.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return false
      Severity: Major
      Found in app/models/user.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return false
        Severity: Major
        Found in app/models/user.rb - About 30 mins to fix

          Method redirect_if_maintenance_mode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def redirect_if_maintenance_mode
    if check_maintenance_mode &&
        controller_name != 'devise/sessions' &&
        controller_name != 'static_page' &&
        !current_user.nil?
          Severity: Minor
          Found in app/controllers/application_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method omniauth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.omniauth(auth_data, signed_in_resource=nil)

    logger.debug "=================================="
    logger.debug "Connexion depuis le CAS uid : "+auth_data[:uid]
    logger.debug "Infos de connection :"
          Severity: Minor
          Found in app/models/user.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  format.html { redirect_to @user, notice: I18n.translate('users.flash.create.success', users: @user.fullname) }
        format.json { render :show, status: :created, location: @user }
          Severity: Minor
          Found in app/controllers/users_controller.rb and 2 other locations - About 15 mins to fix
          app/controllers/users_controller.rb on lines 67..68
          app/controllers/users_controller.rb on lines 93..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    format.html { redirect_to @user, notice: I18n.translate('users.flash.sync.success', users: @user.fullname) }
          format.json { render :show, status: :ok, location: @user }
          Severity: Minor
          Found in app/controllers/users_controller.rb and 2 other locations - About 15 mins to fix
          app/controllers/users_controller.rb on lines 50..51
          app/controllers/users_controller.rb on lines 67..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  format.html { redirect_to @user, notice: I18n.translate('users.flash.update.success', users: @user.fullname) }
        format.json { render :show, status: :ok, location: @user }
          Severity: Minor
          Found in app/controllers/users_controller.rb and 2 other locations - About 15 mins to fix
          app/controllers/users_controller.rb on lines 50..51
          app/controllers/users_controller.rb on lines 93..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language