Sign upLogin

gadzorg/gram2_api_server

View on GitHub
Star
app/controllers/api/v2/accounts_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

File accounts_controller.rb has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Api::V2::AccountsController < Api::V2::BaseController
  before_action :set_api_v2_account,
                only: %i[
                  show
                  edit
Severity: Minor
Found in app/controllers/api/v2/accounts_controller.rb - About 2 hrs to fix

    Method index has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
    filter =
      params.permit(
        :hruid,
        :id_soce,
    Severity: Minor
    Found in app/controllers/api/v2/accounts_controller.rb - About 1 hr to fix

      Method api_v2_account_params has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def api_v2_account_params
    params.require(:account).permit(
      :uuid,
      :hruid,
      :id_soce,
      Severity: Minor
      Found in app/controllers/api/v2/accounts_controller.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def add_to_group
    @group = MasterData::Group.find_by(uuid: params[:group_uuid])
    @groups = @account.groups
    authorize @group, :edit?
        Severity: Major
        Found in app/controllers/api/v2/accounts_controller.rb and 1 other location - About 1 hr to fix
        app/controllers/api/v2/accounts_controller.rb on lines 222..238

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def add_role
    @role = MasterData::Role.find_by!(uuid: params[:role_uuid])
    @roles = @account.roles
    authorize @role, :edit?
        Severity: Major
        Found in app/controllers/api/v2/accounts_controller.rb and 1 other location - About 1 hr to fix
        app/controllers/api/v2/accounts_controller.rb on lines 183..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def revoke_role
    role = @account.roles.find_by!(uuid: params[:role_uuid])
    authorize role, :edit?

    respond_to do |format|
        Severity: Minor
        Found in app/controllers/api/v2/accounts_controller.rb and 1 other location - About 35 mins to fix
        app/controllers/api/v2/accounts_controller.rb on lines 204..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def remove_from_group
    group = @account.groups.find_by(uuid: params[:group_uuid])
    authorize group, :edit?
    respond_to do |format|
      if @account.remove_from_group group
        Severity: Minor
        Found in app/controllers/api/v2/accounts_controller.rb and 1 other location - About 35 mins to fix
        app/controllers/api/v2/accounts_controller.rb on lines 243..253

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status