galetahub/ckeditor

View on GitHub

Showing 42 of 42 total issues

File fileuploader.js has 893 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * http://github.com/valums/file-uploader
 * 
 * Multiple file upload component with progress-bar, drag-and-drop. 
 * © 2010 Andrew Valums ( andrew(at)valums.com ) 

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        _setupDragDrop: function(){
            var self = this,
                dropArea = this._find(this._element, 'drop');
    
            var dz = new qq.UploadDropZone({
    app/assets/javascripts/ckeditor/filebrowser/javascripts/fileuploader.js on lines 585..624

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 376.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        _setupDragDrop: function(){
            var self = this,
                dropArea = this._find(this._element, 'drop');                        
    
            var dz = new qq.UploadDropZone({
    app/assets/javascripts/ckeditor/filebrowser/javascripts/application.js on lines 113..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 376.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function obj2url has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    qq.obj2url = function(obj, temp, prefixDone){
        var uristrings = [],
            prefix = '&',
            add = function(nextObj, i){
                var nextTemp = temp 

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleRemote has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        handleRemote: function(element) {
          var method, url, data,
            crossDomain = element.data('cross-domain') || null,
            dataType = element.data('type') || ($.ajaxSettings && $.ajaxSettings.dataType),
            options;
    Severity: Minor
    Found in app/assets/javascripts/ckeditor/filebrowser/javascripts/rails.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      qq.detach = function(element, type, fn){
          if (element.removeEventListener){
              element.removeEventListener(type, fn, false);
          } else if (element.attachEvent){
              element.detachEvent('on' + type, fn);
      app/assets/javascripts/ckeditor/filebrowser/javascripts/fileuploader.js on lines 53..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      qq.attach = function(element, type, fn){
          if (element.addEventListener){
              element.addEventListener(type, fn, false);
          } else if (element.attachEvent){
              element.attachEvent('on' + type, fn);
      app/assets/javascripts/ckeditor/filebrowser/javascripts/fileuploader.js on lines 60..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (loaded != total){
                  text = Math.round(loaded / total * 100) + '% from ' + this._formatSize(total);
              } else {
                  text = this._formatSize(total);
              }
      app/assets/javascripts/ckeditor/filebrowser/javascripts/fileuploader.js on lines 637..641

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (loaded != total){
                  text = Math.round(loaded / total * 100) + '% from ' + this._formatSize(total);
              } else {                                   
                  text = this._formatSize(total);
              }          
      app/assets/javascripts/ckeditor/filebrowser/javascripts/application.js on lines 164..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function init has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              init: function(options, obj) {
                  obj.options = $.extend({
                      nextPage: ".pagination a[rel=next]",
                      previousPage: ".pagination a[rel=previous]"
                  }, options);

        Function FileUploaderBasic has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        qq.FileUploaderBasic = function(o){
            this._options = {
                // set to true to see the server response
                debug: false,
                action: '/server/upload',

          Function _createInput has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _createInput: function(){                
                  var input = document.createElement("input");
                  
                  if (this._options.multiple){
                      input.setAttribute("multiple", "multiple");

            Function FileUploader has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            qq.FileUploader = function(o){
                // call parent constructor
                qq.FileUploaderBasic.apply(this, arguments);
                
                // additional options    

              Function obj2url has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              qq.obj2url = function(obj, temp, prefixDone){
                  var uristrings = [],
                      prefix = '&',
                      add = function(nextObj, i){
                          var nextTemp = temp 

                Function loadPage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        loadPage: function(url, placement, callback) {
                            //The hash with methods list
                            //depends from placement
                            var actions = {
                                    top: {

                  Function _setupDragDrop has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      _setupDragDrop: function(){
                          var self = this,
                              dropArea = this._find(this._element, 'drop');
                  
                          var dz = new qq.UploadDropZone({

                    Function _setupDragDrop has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        _setupDragDrop: function(){
                            var self = this,
                                dropArea = this._find(this._element, 'drop');                        
                    
                            var dz = new qq.UploadDropZone({

                      Function _upload has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          _upload: function(id, params){
                              var file = this._files[id],
                                  name = this.getName(id),
                                  size = this.getSize(id);
                                      

                        Function _attachEvents has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            _attachEvents: function(){
                                var self = this;              
                                          
                                qq.attach(self._element, 'dragover', function(e){
                                    if (!self._isValidFileDrag(e)) return;

                          Function scrollHandler has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  scrollHandler: function(ev) {
                                      var $scrollable = this.scrollContainer,
                                          $entities = this.entities,
                                          $firstEntity = $entities.first(),
                                          $lastEntity = $entities.last();
                            Severity
                            Category
                            Status
                            Source
                            Language