Sign upLogin

gam6itko/jms-serializer-config-converter

View on GitHub
Star
src/Denormalizer/XmlDenormalizer.php

Summary

Maintainability
D
2 days
Test Coverage

Function toString has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Confirmed

    public function toString(ClassConfig $config): string
    {
        $xml = new \SimpleXMLElement('<?xml version="1.0" encoding="UTF-8" ?><serializer/>');
        $classEl = $xml->addChild('class');
Severity: Minor
Found in src/Denormalizer/XmlDenormalizer.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toString has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toString(ClassConfig $config): string
    {
        $xml = new \SimpleXMLElement('<?xml version="1.0" encoding="UTF-8" ?><serializer/>');
        $classEl = $xml->addChild('class');
Severity: Major
Found in src/Denormalizer/XmlDenormalizer.php - About 2 hrs to fix

    Function addProperty has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        private function addProperty(\SimpleXMLElement $classEl, string $nodeName, $config)
    {
        $propEl = $classEl->addChild($nodeName);
        $properties = $this->extractClassPropertyTypes(new \ReflectionClass($config));
        foreach ($properties as $propertyName => $type) {
    Severity: Minor
    Found in src/Denormalizer/XmlDenormalizer.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addProperty has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function addProperty(\SimpleXMLElement $classEl, string $nodeName, $config)
    {
        $propEl = $classEl->addChild($nodeName);
        $properties = $this->extractClassPropertyTypes(new \ReflectionClass($config));
        foreach ($properties as $propertyName => $type) {
    Severity: Minor
    Found in src/Denormalizer/XmlDenormalizer.php - About 1 hr to fix

      Function setAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setAttribute($classEl, $propertyName, $type, $value)
    {
        if (null === $value) {
            return;
        }
      Severity: Minor
      Found in src/Denormalizer/XmlDenormalizer.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status