Sign upLogin

gam6itko/jms-serializer-config-converter

View on GitHub
Star
src/Normalizer/XmlNormalizer.php

Summary

Maintainability
F
3 days
Test Coverage

Function loadFromFile has a Cognitive Complexity of 107 (exceeds 5 allowed). Consider refactoring.
Confirmed

    protected function loadFromFile(\ReflectionClass $class, string $path): ?ClassConfig
    {
        $previous = libxml_use_internal_errors(true);
        libxml_clear_errors();
Severity: Minor
Found in src/Normalizer/XmlNormalizer.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadFromFile has 185 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

    protected function loadFromFile(\ReflectionClass $class, string $path): ?ClassConfig
    {
        $previous = libxml_use_internal_errors(true);
        libxml_clear_errors();
Severity: Major
Found in src/Normalizer/XmlNormalizer.php - About 7 hrs to fix

    Function parseDiscriminator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function parseDiscriminator(\SimpleXMLElement $elem)
    {
        $discriminator = new DiscriminatorConfig();
        $discriminator->fieldName = (string) $elem->attributes()->{'discriminator-field-name'};
        $discriminator->disabled = filter_var($elem->attributes()->{'discriminator-disabled'}, FILTER_VALIDATE_BOOLEAN);
    Severity: Minor
    Found in src/Normalizer/XmlNormalizer.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status