Sign upLogin

garak/pokerino

View on GitHub
Star

Showing 23 of 23 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Garak\Pokerino\Rank;

use Garak\Pokerino\CardSorter;
Severity: Major
Found in src/Rank/ThreeOfAKindRank.php and 2 other locations - About 6 hrs to fix
src/Rank/FlushRank.php on lines 1..35
src/Rank/PairRank.php on lines 1..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 210.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Garak\Pokerino\Rank;

use Garak\Pokerino\CardSorter;
Severity: Major
Found in src/Rank/FlushRank.php and 2 other locations - About 6 hrs to fix
src/Rank/PairRank.php on lines 1..35
src/Rank/ThreeOfAKindRank.php on lines 1..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 210.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Garak\Pokerino\Rank;

use Garak\Pokerino\CardSorter;
Severity: Major
Found in src/Rank/PairRank.php and 2 other locations - About 6 hrs to fix
src/Rank/FlushRank.php on lines 1..35
src/Rank/ThreeOfAKindRank.php on lines 1..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 210.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function isPoint has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public static function isPoint(array $cards): RankResult
    {
        $high = null;
        $kicker = null;
        // check if there's a three: in this case, we remove one card
Severity: Minor
Found in src/Rank/StraightRank.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (4 === \max($sequence, $maxSequence)) {
            $maxKey = \array_search($max, $values, true);
            foreach ($cards as $card) {
                if ($card->getRank()->getInt() === $values[$maxKey]) {
                    $high = $card;
Severity: Major
Found in src/Rank/StraightFlushRank.php and 1 other location - About 2 hrs to fix
src/Rank/StraightRank.php on lines 52..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (4 === \max($sequence, $maxSequence)) {
            $maxKey = \array_search($max, $values, true);
            foreach ($cards as $card) {
                if ($card->getRank()->getInt() === $values[$maxKey]) {
                    $high = $card;
Severity: Major
Found in src/Rank/StraightRank.php and 1 other location - About 2 hrs to fix
src/Rank/StraightFlushRank.php on lines 27..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method isPoint has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function isPoint(array $cards): RankResult
    {
        $high = null;
        $kicker = null;
        // check if there's a three: in this case, we remove one card
Severity: Major
Found in src/Rank/StraightRank.php - About 2 hrs to fix

    Function isPoint has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isPoint(array $cards): RankResult
    {
        $counts = \array_count_values(self::getCardsSuits($cards));
        if (!\in_array(5, $counts, true)) {
            return new RankResult(false);
    Severity: Minor
    Found in src/Rank/RoyalFlushRank.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isPoint has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isPoint(array $cards): RankResult
    {
        $counts = \array_count_values(self::getCardsSuits($cards));
        if (!\in_array(5, $counts, true)) {
            return new RankResult(false);
    Severity: Minor
    Found in src/Rank/StraightFlushRank.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            foreach ($values as $key => $value) {
            if (null !== $prev && 1 === $value - $prev) {
                $max = $value;
                ++$sequence;
            } else {
    Severity: Major
    Found in src/Rank/AbstractRank.php and 1 other location - About 1 hr to fix
    src/Rank/StraightRank.php on lines 34..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            foreach ($values as $key => $value) {
            if (null !== $prev && 1 === $value - $prev) {
                $max = $value;
                ++$sequence;
            } else {
    Severity: Major
    Found in src/Rank/StraightRank.php and 1 other location - About 1 hr to fix
    src/Rank/AbstractRank.php on lines 88..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function straight has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static function straight(array $cards): array
    {
        // check if there's a three: in this case, we remove one card
        $three = ThreeOfAKindRank::isPoint($cards);
        if ($three->isPoint()) {
    Severity: Minor
    Found in src/Rank/AbstractRank.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isPoint has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isPoint(array $cards): RankResult
    {
        $high = null;
        $kicker = null;
        $counts = \array_count_values(self::getCardsValues($cards));
    Severity: Minor
    Found in src/Rank/FullHouseRank.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deal has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function deal(int $startingHandCount = 2, int $commonCount = 5): void
    {
        $cards = Card::getDeck(true);
        for ($i = 0; $i < $this->players->count(); ++$i) {
            $handCards = [];
    Severity: Minor
    Found in src/Game.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method isPoint has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function isPoint(array $cards): RankResult
    {
        $counts = \array_count_values(self::getCardsSuits($cards));
        if (!\in_array(5, $counts, true)) {
            return new RankResult(false);
    Severity: Minor
    Found in src/Rank/RoyalFlushRank.php - About 1 hr to fix

      Method straight has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected static function straight(array $cards): array
    {
        // check if there's a three: in this case, we remove one card
        $three = ThreeOfAKindRank::isPoint($cards);
        if ($three->isPoint()) {
      Severity: Minor
      Found in src/Rank/AbstractRank.php - About 1 hr to fix

        Method isPoint has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function isPoint(array $cards): RankResult
    {
        $counts = \array_count_values(self::getCardsSuits($cards));
        if (!\in_array(5, $counts, true)) {
            return new RankResult(false);
        Severity: Minor
        Found in src/Rank/StraightFlushRank.php - About 1 hr to fix

          Function isPoint has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function isPoint(array $cards): RankResult
    {
        $high = null;
        $kicker = null;
        $counts = \array_count_values(self::getCardsValues($cards));
          Severity: Minor
          Found in src/Rank/TwoPairRank.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function isPoint has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function isPoint(array $cards): RankResult
    {
        $high = null;
        $kicker = null;
        $counts = \array_count_values(self::getCardsSuits($cards));
          Severity: Minor
          Found in src/Rank/FlushRank.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function isPoint has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function isPoint(array $cards): RankResult
    {
        $high = null;
        $kicker = null;
        $counts = \array_count_values(self::getCardsValues($cards));
          Severity: Minor
          Found in src/Rank/ThreeOfAKindRank.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language