Function parse
has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring. Open
private function parse()
{
if (!empty($this->chars)) {
return;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parse()
{
if (!empty($this->chars)) {
return;
}
Method cpToUtf8Char
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected static function cpToUtf8Char($cpt)
{
if ($cpt < self::$spec[2]['start']) {
return \chr($cpt);
}
Function cpToUtf8Char
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected static function cpToUtf8Char($cpt)
{
if ($cpt < self::$spec[2]['start']) {
return \chr($cpt);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return 5;
Avoid too many return
statements within this method. Open
return false;
Avoid too many return
statements within this method. Open
return 6;
Function charLength
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
protected static function charLength($byte)
{
if ($byte < 192) {
return 1;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method parse() has an NPath complexity of 886. The configured NPath complexity threshold is 200. Open
private function parse()
{
if (!empty($this->chars)) {
return;
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method parse() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10. Open
private function parse()
{
if (!empty($this->chars)) {
return;
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method cpToUtf8Char uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$data = [
0b11110100,
0b10000000 | (($cpt >> 12) & 0b00111111),
0b10000000 | (($cpt >> 6) & 0b00111111),
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Function closing brace must go on the next line following the body; found 1 blank lines before brace Open
}
- Exclude checks