gartz/pushStateTree

View on GitHub

Showing 21 of 21 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function (root) {
  "use strict";

  var document = root.document;
  var window = root.window;
Severity: Major
Found in src/pushStateTree.js and 1 other location - About 1 mo to fix
push-state-tree.js on lines 6..1106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 7812.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function (root) {
  "use strict";

  var document = root.document;
  var window = root.window;
Severity: Major
Found in push-state-tree.js and 1 other location - About 1 mo to fix
src/pushStateTree.js on lines 1..1101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 7812.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File push-state-tree.js has 794 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//! push-state-tree - v0.16.0 - 2024-03-30
//* https://github.com/gartz/pushStateTree/
//* Copyright (c) 2024 Gabriel Reitz Giannattasio <g@rtz.sh>; Licensed 

var PushStateTree = {options: {VERSION: '0.16.0'}};
Severity: Major
Found in push-state-tree.js - About 1 day to fix

    File pushStateTree.js has 793 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function (root) {
      "use strict";
    
      var document = root.document;
      var window = root.window;
    Severity: Major
    Found in src/pushStateTree.js - About 1 day to fix

      Function exports has 223 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {
      
        grunt.initConfig({
          meta: {
            pkg: grunt.file.readJSON('package.json'),
      Severity: Major
      Found in Gruntfile.js - About 1 day to fix

        Function PushStateTree has 181 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function PushStateTree(options) {
            options = options || {};
            // Enforce the usage of PushState API, available on all modern browsers.
            // True by default
            options[USE_PUSH_STATE] = options[USE_PUSH_STATE] !== false;
        Severity: Major
        Found in src/pushStateTree.js - About 7 hrs to fix

          Function PushStateTree has 181 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function PushStateTree(options) {
              options = options || {};
              // Enforce the usage of PushState API, available on all modern browsers.
              // True by default
              options[USE_PUSH_STATE] = options[USE_PUSH_STATE] !== false;
          Severity: Major
          Found in push-state-tree.js - About 7 hrs to fix

            Function rulesDispatcher has 122 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                rulesDispatcher: function () {
                  // Will dispatch the right events in each rule
                  /*jshint validthis:true */
            
                  // Cache the URI, in case of an event try to change it
            Severity: Major
            Found in push-state-tree.js - About 4 hrs to fix

              Function rulesDispatcher has 122 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  rulesDispatcher: function () {
                    // Will dispatch the right events in each rule
                    /*jshint validthis:true */
              
                    // Cache the URI, in case of an event try to change it
              Severity: Major
              Found in src/pushStateTree.js - About 4 hrs to fix

                Function recursiveDispatcher has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      function recursiveDispatcher(uri, oldURI, ruleElement) {
                        if (!ruleElement.rule) return;
                
                        var useURI = uri;
                        var useOldURI = oldURI;
                Severity: Major
                Found in src/pushStateTree.js - About 3 hrs to fix

                  Function recursiveDispatcher has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        function recursiveDispatcher(uri, oldURI, ruleElement) {
                          if (!ruleElement.rule) return;
                  
                          var useURI = uri;
                          var useOldURI = oldURI;
                  Severity: Major
                  Found in push-state-tree.js - About 3 hrs to fix

                    Function createRule has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        createRule: function (options) {
                          // Create a pushstreamtree-rule element from a literal object
                    
                          var rule = document.createElement("pushstatetree-rule");
                    
                    
                    Severity: Major
                    Found in push-state-tree.js - About 2 hrs to fix

                      Function createRule has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          createRule: function (options) {
                            // Create a pushstreamtree-rule element from a literal object
                      
                            var rule = document.createElement("pushstatetree-rule");
                      
                      
                      Severity: Major
                      Found in src/pushStateTree.js - About 2 hrs to fix

                        Function removeEventListenerFunc has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            var removeEventListenerFunc = function (type, handler) {
                              if (!this.__bindedFunctions) {
                                this.__bindedFunctions = [];
                              }
                        
                        
                        Severity: Minor
                        Found in src/pushStateTree.js - About 1 hr to fix

                          Function removeEventListenerFunc has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              var removeEventListenerFunc = function (type, handler) {
                                if (!this.__bindedFunctions) {
                                  this.__bindedFunctions = [];
                                }
                          
                          
                          Severity: Minor
                          Found in push-state-tree.js - About 1 hr to fix

                            Function get has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                  get: function () {
                                    if (cachedUri.url === root.location.href) return cachedUri.uri;
                            
                                    var ignoreHash = options[IGNORE_HASH];
                            
                            
                            Severity: Minor
                            Found in push-state-tree.js - About 1 hr to fix

                              Function get has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                    get: function () {
                                      if (cachedUri.url === root.location.href) return cachedUri.uri;
                              
                                      var ignoreHash = options[IGNORE_HASH];
                              
                              
                              Severity: Minor
                              Found in src/pushStateTree.js - About 1 hr to fix

                                Function addEventListenerFunc has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    var addEventListenerFunc = function (type, handler) {
                                      if (!this.__bindedFunctions) {
                                        this.__bindedFunctions = [];
                                      }
                                
                                
                                Severity: Minor
                                Found in push-state-tree.js - About 1 hr to fix

                                  Function addEventListenerFunc has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      var addEventListenerFunc = function (type, handler) {
                                        if (!this.__bindedFunctions) {
                                          this.__bindedFunctions = [];
                                        }
                                  
                                  
                                  Severity: Minor
                                  Found in src/pushStateTree.js - About 1 hr to fix

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                      var ready = $.ajax(demoPath + 'api.html').done(function (tmpl){
                                        $about = $(tmpl);
                                      });
                                    Severity: Minor
                                    Found in demo/api.js and 1 other location - About 35 mins to fix
                                    demo/about.js on lines 15..17

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 46.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language