gboudreau/Greyhole

View on GitHub
includes/CLI/MoveCliRunner.php

Summary

Maintainability
C
1 day
Test Coverage

Function run has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function run() {
        Log::setAction(ACTION_INITIALIZE);
        Metastores::choose_metastores_backups();
        Log::setAction(ACTION_MOVE);

Severity: Minor
Found in includes/CLI/MoveCliRunner.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run() {
        Log::setAction(ACTION_INITIALIZE);
        Metastores::choose_metastores_backups();
        Log::setAction(ACTION_MOVE);

Severity: Major
Found in includes/CLI/MoveCliRunner.php - About 2 hrs to fix

    Method move_file has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected static function move_file($source, $destination) {
            echo "[INFO] Moving file: $source > $destination\n";
    
            $source_parts = explode('/', $source);
            $source_share = array_shift($source_parts);
    Severity: Minor
    Found in includes/CLI/MoveCliRunner.php - About 1 hr to fix

      Function move_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function move_file($source, $destination) {
              echo "[INFO] Moving file: $source > $destination\n";
      
              $source_parts = explode('/', $source);
              $source_share = array_shift($source_parts);
      Severity: Minor
      Found in includes/CLI/MoveCliRunner.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status