Sign upLogin

gboudreau/Greyhole

View on GitHub
Star
includes/SambaUtils.php

Summary

Maintainability
C
1 day
Test Coverage

Function samba_restart has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public static function samba_restart() {
        Log::info("The Samba daemon will now restart...");
        if (is_file('/etc/init/smbd.conf')) {
            exec("/sbin/restart smbd");
        } else if (is_file('/etc/init.d/samba')) {
Severity: Minor
Found in includes/SambaUtils.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function samba_check_vfs has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public static function samba_check_vfs() {
        $vfs_is_ok = FALSE;

        // Samba version
        $version = str_replace('.', '', SambaUtils::samba_get_version());
Severity: Minor
Found in includes/SambaUtils.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method samba_check_vfs has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function samba_check_vfs() {
        $vfs_is_ok = FALSE;

        // Samba version
        $version = str_replace('.', '', SambaUtils::samba_get_version());
Severity: Major
Found in includes/SambaUtils.php - About 2 hrs to fix

    There are no issues that match your filters.

    Category
    Status