Sign upLogin

gdbots/ncr-bundle-php

View on GitHub
Star

Showing 38 of 38 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Bundle\NcrBundle\Command;
Severity: Major
Found in src/Command/CreateStorageCommand.php and 1 other location - About 2 days to fix
src/Command/CreateSearchStorageCommand.php on lines 1..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 556.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Bundle\NcrBundle\Command;
Severity: Major
Found in src/Command/CreateSearchStorageCommand.php and 1 other location - About 2 days to fix
src/Command/CreateStorageCommand.php on lines 1..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 556.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Bundle\NcrBundle\Command;
Severity: Major
Found in src/Command/DescribeStorageCommand.php and 1 other location - About 2 days to fix
src/Command/DescribeSearchStorageCommand.php on lines 1..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 546.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Bundle\NcrBundle\Command;
Severity: Major
Found in src/Command/DescribeSearchStorageCommand.php and 1 other location - About 2 days to fix
src/Command/DescribeStorageCommand.php on lines 1..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 546.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getElasticaNcrSearchConfigTree has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getElasticaNcrSearchConfigTree(): NodeDefinition
    {
        $treeBuilder = new TreeBuilder('elastica');
        $node = $treeBuilder->getRootNode();
Severity: Major
Found in src/DependencyInjection/Configuration.php - About 5 hrs to fix

    Method getConfigTreeBuilder has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getConfigTreeBuilder(): TreeBuilder
    {
        $treeBuilder = new TreeBuilder('gdbots_ncr');
        $rootNode = $treeBuilder->getRootNode();
    Severity: Major
    Found in src/DependencyInjection/Configuration.php - About 3 hrs to fix

      File Configuration.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
declare(strict_types=1);

namespace Gdbots\Bundle\NcrBundle\DependencyInjection;
      Severity: Minor
      Found in src/DependencyInjection/Configuration.php - About 2 hrs to fix

        Method execute has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $batchSize = NumberUtil::bound((int)$input->getOption('batch-size'), 1, 2000);
        $batchDelay = NumberUtil::bound((int)$input->getOption('batch-delay'), 10, 600000);
        $context = $input->getOption('context') ?: '{}';
        Severity: Major
        Found in src/Command/SyncNodesCommand.php - About 2 hrs to fix

          Method execute has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $dryRun = $input->getOption('dry-run');
        $skipErrors = $input->getOption('skip-errors');
        $batchSize = NumberUtil::bound((int)$input->getOption('batch-size'), 1, 2000);
          Severity: Major
          Found in src/Command/ReindexNodesCommand.php - About 2 hrs to fix

            Method configure has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function configure(): void
    {
        $provider = $this->container->getParameter('gdbots_ncr.ncr.provider');
        $searchProvider = $this->container->getParameter('gdbots_ncr.ncr_search.provider');
            Severity: Major
            Found in src/Command/ReindexNodesCommand.php - About 2 hrs to fix

              Method getDynamoDbNcrConfigTree has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function getDynamoDbNcrConfigTree(): NodeDefinition
    {
        $treeBuilder = new TreeBuilder('dynamodb');
        $node = $treeBuilder->getRootNode();
              Severity: Minor
              Found in src/DependencyInjection/Configuration.php - About 1 hr to fix

                Method configure has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function configure(): void
    {
        $provider = $this->container->getParameter('gdbots_ncr.ncr.provider');
        $searchProvider = $this->container->getParameter('gdbots_ncr.ncr_search.provider');
        $eventStoreProvider = $this->container->getParameter('gdbots_pbjx.event_store.provider');
                Severity: Minor
                Found in src/Command/SyncNodesCommand.php - About 1 hr to fix

                  Function toNodeRef has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function toNodeRef(mixed $val): ?NodeRef
    {
        if ($val instanceof NodeRef) {
            return $val;
        } else if (empty($val)) {
                  Severity: Minor
                  Found in src/Twig/NcrExtension.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method configure has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function configure(): void
    {
        $provider = $this->container->getParameter('gdbots_ncr.ncr.provider');

        $this
                  Severity: Minor
                  Found in src/Command/ExportNodesCommand.php - About 1 hr to fix

                    Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $batchSize = NumberUtil::bound((int)$input->getOption('batch-size'), 1, 2000);
        $batchDelay = NumberUtil::bound((int)$input->getOption('batch-delay'), 10, 600000);
        $context = $input->getOption('context') ?: '{}';
                    Severity: Minor
                    Found in src/Command/SyncNodesCommand.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method configure has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function configure(): void
    {
        $provider = $this->container->getParameter('gdbots_ncr.ncr.provider');

        $this
                    Severity: Minor
                    Found in src/Command/GetNodeCommand.php - About 1 hr to fix

                      Method execute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $noShapshot = $input->getOption('no-snapshot');
        $context = $input->getOption('context') ?: '{}';
        if (!str_contains($context, '{')) {
                      Severity: Minor
                      Found in src/Command/SyncNodeCommand.php - About 1 hr to fix

                        Method configure has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function configure(): void
    {
        $provider = $this->container->getParameter('gdbots_ncr.ncr.provider');
        $searchProvider = $this->container->getParameter('gdbots_ncr.ncr_search.provider');
        $eventStoreProvider = $this->container->getParameter('gdbots_pbjx.event_store.provider');
                        Severity: Minor
                        Found in src/Command/SyncNodeCommand.php - About 1 hr to fix

                          Method execute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $errOutput = $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output;
        $output->setVerbosity(OutputInterface::VERBOSITY_QUIET);
        $errOutput->setVerbosity(OutputInterface::VERBOSITY_NORMAL);
                          Severity: Minor
                          Found in src/Command/ExportNodesCommand.php - About 1 hr to fix

                            Method execute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $skipErrors = $input->getOption('skip-errors');
        $context = $input->getOption('context') ?: '{}';
        if (!str_contains($context, '{')) {
                            Severity: Minor
                            Found in src/Command/CreateSearchStorageCommand.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language