Sign upLogin

gdbots/ncr-php

View on GitHub
Star
src/Aggregate.php

Summary

Maintainability
F
4 days
Test Coverage

File Aggregate.php has 665 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Ncr;
Severity: Major
Found in src/Aggregate.php - About 1 day to fix

    Aggregate has 62 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Aggregate
{
    protected Message $node;
    protected NodeRef $nodeRef;
    protected Pbjx $pbjx;
    Severity: Major
    Found in src/Aggregate.php - About 1 day to fix

      Method updateNode has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateNode(Message $command): void
    {
        /** @var NodeRef $nodeRef */
        $nodeRef = $command->get('node_ref');
        $this->assertNodeRefMatches($nodeRef);
      Severity: Minor
      Found in src/Aggregate.php - About 1 hr to fix

        Method publishNode has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function publishNode(Message $command, ?\DateTimeZone $localTimeZone = null): void
    {
        if (!$this->node::schema()->hasMixin('gdbots:ncr:mixin:publishable')) {
            throw new InvalidArgumentException(
                "Node [{$this->nodeRef}] must have [gdbots:ncr:mixin:publishable]."
        Severity: Minor
        Found in src/Aggregate.php - About 1 hr to fix

          Function updateNode has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateNode(Message $command): void
    {
        /** @var NodeRef $nodeRef */
        $nodeRef = $command->get('node_ref');
        $this->assertNodeRefMatches($nodeRef);
          Severity: Minor
          Found in src/Aggregate.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function publishNode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function publishNode(Message $command, ?\DateTimeZone $localTimeZone = null): void
    {
        if (!$this->node::schema()->hasMixin('gdbots:ncr:mixin:publishable')) {
            throw new InvalidArgumentException(
                "Node [{$this->nodeRef}] must have [gdbots:ncr:mixin:publishable]."
          Severity: Minor
          Found in src/Aggregate.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function lockNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function lockNode(Message $command): void
    {
        if (!$this->node::schema()->hasMixin('gdbots:ncr:mixin:lockable')) {
            throw new InvalidArgumentException(
                "Node [{$this->nodeRef}] must have [gdbots:ncr:mixin:lockable]."
          Severity: Minor
          Found in src/Aggregate.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function markNodeAsDraft(Message $command): void
    {
        if (!$this->node::schema()->hasMixin('gdbots:ncr:mixin:publishable')) {
            throw new InvalidArgumentException(
                "Node [{$this->nodeRef}] must have [gdbots:ncr:mixin:publishable]."
          Severity: Major
          Found in src/Aggregate.php and 1 other location - About 4 hrs to fix
          src/Aggregate.php on lines 351..377

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 169.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function markNodeAsPending(Message $command): void
    {
        if (!$this->node::schema()->hasMixin('gdbots:ncr:mixin:publishable')) {
            throw new InvalidArgumentException(
                "Node [{$this->nodeRef}] must have [gdbots:ncr:mixin:publishable]."
          Severity: Major
          Found in src/Aggregate.php and 1 other location - About 4 hrs to fix
          src/Aggregate.php on lines 323..349

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 169.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status