Sign upLogin

gdbots/ncr-php

View on GitHub
Star
src/Repository/DynamoDb/DynamoDbNcr.php

Summary

Maintainability
F
5 days
Test Coverage

File DynamoDbNcr.php has 585 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Ncr\Repository\DynamoDb;
Severity: Major
Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 day to fix

    Method doPipeNodes has 162 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function doPipeNodes(SchemaQName $qname, array $context): \Generator
    {
        static $alreadyPiped = [];

        $tableName = $context['table_name'] ?? $this->tableManager->getNodeTableName($qname, $context);
    Severity: Major
    Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 6 hrs to fix

      Function doPipeNodes has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          private function doPipeNodes(SchemaQName $qname, array $context): \Generator
    {
        static $alreadyPiped = [];

        $tableName = $context['table_name'] ?? $this->tableManager->getNodeTableName($qname, $context);
      Severity: Minor
      Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method findNodeRefs has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findNodeRefs(IndexQuery $query, array $context = []): IndexQueryResult
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($query->getQName(), $context);
        $table = $this->tableManager->getNodeTable($query->getQName());
      Severity: Major
      Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 3 hrs to fix

        Function findNodeRefs has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function findNodeRefs(IndexQuery $query, array $context = []): IndexQueryResult
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($query->getQName(), $context);
        $table = $this->tableManager->getNodeTable($query->getQName());
        Severity: Minor
        Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getNode has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getNode(NodeRef $nodeRef, bool $consistent = false, array $context = []): Message
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($nodeRef->getQName(), $context);
        Severity: Major
        Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 2 hrs to fix

          Method putNode has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function putNode(Message $node, ?string $expectedEtag = null, array $context = []): void
    {
        $node->freeze();
        $nodeRef = $node->generateNodeRef();
          Severity: Minor
          Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 2 hrs to fix

            Method getNodes has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getNodes(array $nodeRefs, bool $consistent = false, array $context = []): array
    {
        $context = $this->enrichContext(__FUNCTION__, $context);

        if (empty($nodeRefs)) {
            Severity: Minor
            Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 hr to fix

              Method hasNode has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function hasNode(NodeRef $nodeRef, bool $consistent = false, array $context = []): bool
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($nodeRef->getQName(), $context);
              Severity: Minor
              Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 hr to fix

                Function getNode has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getNode(NodeRef $nodeRef, bool $consistent = false, array $context = []): Message
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($nodeRef->getQName(), $context);
                Severity: Minor
                Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method deleteNode has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function deleteNode(NodeRef $nodeRef, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($nodeRef->getQName(), $context);
                Severity: Minor
                Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 hr to fix

                  Function getNodes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getNodes(array $nodeRefs, bool $consistent = false, array $context = []): array
    {
        $context = $this->enrichContext(__FUNCTION__, $context);

        if (empty($nodeRefs)) {
                  Severity: Minor
                  Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function putNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function putNode(Message $node, ?string $expectedEtag = null, array $context = []): void
    {
        $node->freeze();
        $nodeRef = $node->generateNodeRef();
                  Severity: Minor
                  Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function deleteNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function deleteNode(NodeRef $nodeRef, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($nodeRef->getQName(), $context);
                  Severity: Minor
                  Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function hasNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function hasNode(NodeRef $nodeRef, bool $consistent = false, array $context = []): bool
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->tableManager->getNodeTableName($nodeRef->getQName(), $context);
                  Severity: Minor
                  Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          DynamoDbClient $client,
        EventDispatcher $dispatcher,
        TableManager $tableManager,
        array $config = [],
        ?LoggerInterface $logger = null
                  Severity: Minor
                  Found in src/Repository/DynamoDb/DynamoDbNcr.php - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function pipeNodes(SchemaQName $qname, array $context = []): \Generator
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $context['node_refs_only'] = false;
        $generator = $this->doPipeNodes($qname, $context);
                    Severity: Major
                    Found in src/Repository/DynamoDb/DynamoDbNcr.php and 1 other location - About 1 hr to fix
                    src/Repository/DynamoDb/DynamoDbNcr.php on lines 455..470

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 107.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function pipeNodeRefs(SchemaQName $qname, array $context = []): \Generator
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $context['node_refs_only'] = true;
        $generator = $this->doPipeNodes($qname, $context);
                    Severity: Major
                    Found in src/Repository/DynamoDb/DynamoDbNcr.php and 1 other location - About 1 hr to fix
                    src/Repository/DynamoDb/DynamoDbNcr.php on lines 438..453

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 107.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status