Sign upLogin

gdbots/pbj-php

View on GitHub
Star
src/AbstractMessage.php

Summary

Maintainability
D
2 days
Test Coverage

File AbstractMessage.php has 447 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Pbj;
Severity: Minor
Found in src/AbstractMessage.php - About 6 hrs to fix

    AbstractMessage has 45 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractMessage implements Message, \JsonSerializable
{
    /** @var Schema[] */
    private static array $schemas = [];
    private static ?PhpArraySerializer $serializer = null;
    Severity: Minor
    Found in src/AbstractMessage.php - About 6 hrs to fix

      Function validate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          final public function validate(bool $strict = false, bool $recursive = false): static
    {
        if (!$strict && $this->isFrozen()) {
            return $this;
        }
      Severity: Minor
      Found in src/AbstractMessage.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getNestedMessages has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getNestedMessages(): array
    {
        $messages = [];
        foreach (static::schema()->getFields() as $field) {
            if ($field->getType()->isMessage()) {
      Severity: Minor
      Found in src/AbstractMessage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return true;
      Severity: Major
      Found in src/AbstractMessage.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/AbstractMessage.php - About 30 mins to fix

          Function isReplay has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              final public function isReplay(?bool $replay = null): bool
    {
        if (null === $replay) {
            if (null === $this->isReplay) {
                $this->isReplay = false;
          Severity: Minor
          Found in src/AbstractMessage.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status