Sign upLogin

gdbots/pbj-php

View on GitHub
Star
src/Marshaler/Elastica/MappingBuilder.php

Summary

Maintainability
C
1 day
Test Coverage

File MappingBuilder.php has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Pbj\Marshaler\Elastica;
Severity: Minor
Found in src/Marshaler/Elastica/MappingBuilder.php - About 3 hrs to fix

    Function buildSchema has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function buildSchema(Schema $schema): array
    {
        $properties = [];

        if ($this->getPathDepth() > static::MAX_PATH_DEPTH) {
    Severity: Minor
    Found in src/Marshaler/Elastica/MappingBuilder.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    MappingBuilder has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class MappingBuilder
{
    /**
     * Generally we use "__" to indicate a derived field but kibana won't recognize it.
     * So for now, we'll use "d__" to indicate a derived field for ES.
    Severity: Minor
    Found in src/Marshaler/Elastica/MappingBuilder.php - About 2 hrs to fix

      Method buildSchema has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function buildSchema(Schema $schema): array
    {
        $properties = [];

        if ($this->getPathDepth() > static::MAX_PATH_DEPTH) {
      Severity: Minor
      Found in src/Marshaler/Elastica/MappingBuilder.php - About 1 hr to fix

        Function getSupportedMessages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getSupportedMessages(Field $field): array
    {
        if (!$field->hasAnyOfCuries()) {
            return MessageResolver::all();
        }
        Severity: Minor
        Found in src/Marshaler/Elastica/MappingBuilder.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $properties;
        Severity: Major
        Found in src/Marshaler/Elastica/MappingBuilder.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $this->withAnalyzer(self::TYPES['text'], $field);
          Severity: Major
          Found in src/Marshaler/Elastica/MappingBuilder.php - About 30 mins to fix

            Function withAnalyzer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function withAnalyzer(array $properties, Field $field): array
    {
        if (null === $this->analyzer) {
            return $properties;
        }
            Severity: Minor
            Found in src/Marshaler/Elastica/MappingBuilder.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status