Sign upLogin

gdbots/pbjc-php

View on GitHub
Star
tests/Generator/JsonSchemaGeneratorTest.php

Summary

Maintainability
C
1 day
Test Coverage

Method getSchemas has 193 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getSchemas()
    {
        return [
            [
                'schema' => new SchemaDescriptor(
Severity: Major
Found in tests/Generator/JsonSchemaGeneratorTest.php - About 7 hrs to fix

    The method getSchemas() has 196 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function getSchemas()
    {
        return [
            [
                'schema' => new SchemaDescriptor(
    Severity: Minor
    Found in tests/Generator/JsonSchemaGeneratorTest.php by phpmd

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                            'fields' => [
                            new FieldDescriptor('string', [
                                'type' => 'string',
                            ]),
                            new FieldDescriptor('int', [
    Severity: Major
    Found in tests/Generator/JsonSchemaGeneratorTest.php and 1 other location - About 5 hrs to fix
    tests/Generator/PhpGeneratorTest.php on lines 55..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 184.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status