Sign upLogin

gdbots/pbjx-bundle-php

View on GitHub
Star
src/Command/PbjxBatchCommand.php

Summary

Maintainability
D
2 days
Test Coverage

Function execute has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $dryRun = $input->getOption('dry-run');
        $skipInvalid = $input->getOption('skip-invalid');
        $skipErrors = $input->getOption('skip-errors');
Severity: Minor
Found in src/Command/PbjxBatchCommand.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $dryRun = $input->getOption('dry-run');
        $skipInvalid = $input->getOption('skip-invalid');
        $skipErrors = $input->getOption('skip-errors');
Severity: Major
Found in src/Command/PbjxBatchCommand.php - About 5 hrs to fix

    Method configure has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function configure(): void
    {
        $this
            ->setDescription('Reads messages from a newline-delimited JSON file and processes them')
            ->setHelp(<<<EOF
    Severity: Major
    Found in src/Command/PbjxBatchCommand.php - About 3 hrs to fix

      File PbjxBatchCommand.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
declare(strict_types=1);

namespace Gdbots\Bundle\PbjxBundle\Command;
      Severity: Minor
      Found in src/Command/PbjxBatchCommand.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $this
            ->setDescription('Reads messages from a newline-delimited JSON file and processes them')
            ->setHelp(<<<EOF
The <info>%command.name%</info> command will read messages (pbj commands or events) from a
newline-delimited JSON file and run pbjx->send or pbjx->publish.
        Severity: Major
        Found in src/Command/PbjxBatchCommand.php and 1 other location - About 1 hr to fix
        src/Command/PbjxCommand.php on lines 31..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status