gdbots/query-parser-php

View on GitHub
src/Node/Numbr.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method '__construct'.
Open

        $this->comparisonOperator = $comparisonOperator ?: ComparisonOperator::EQ();
Severity: Minor
Found in src/Node/Numbr.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'toArray'.
Open

        if ($this->comparisonOperator->equals(ComparisonOperator::EQ())) {
Severity: Minor
Found in src/Node/Numbr.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'fromArray'.
Open

            $comparisonOperator = isset($data['comparison_operator']) ? ComparisonOperator::create($data['comparison_operator']) : null;
Severity: Minor
Found in src/Node/Numbr.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'useComparisonOperator'.
Open

        return !$this->comparisonOperator->equals(ComparisonOperator::EQ());
Severity: Minor
Found in src/Node/Numbr.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Line exceeds 120 characters; contains 136 characters
Open

            $comparisonOperator = isset($data['comparison_operator']) ? ComparisonOperator::create($data['comparison_operator']) : null;
Severity: Minor
Found in src/Node/Numbr.php by phpcodesniffer

There are no issues that match your filters.

Category
Status