Sign upLogin

gecos-team/gecoscc-ui

View on GitHub
Star
gecoscc/api/help_channel_client.py

Summary

Maintainability
C
1 day
Test Coverage

File help_channel_client.py has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-

#
# Copyright 2018, Junta de Andalucia
# http://www.juntadeandalucia.es/
Severity: Minor
Found in gecoscc/api/help_channel_client.py - About 2 hrs to fix

    Function post has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def post(self):
        logger.debug('/help-channel-client/login START') 

        # Default known message
        known_message = 'En un lugar de la Mancha, de cuyo nombre no quiero'\
    Severity: Minor
    Found in gecoscc/api/help_channel_client.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def get(self):
        logger.debug('/help-channel-client/check START') 
        
        # Check the parameters
        token = self.request.GET.get('connection_code')
    Severity: Minor
    Found in gecoscc/api/help_channel_client.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function post has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def post(self):
        logger.debug('/help-channel-client/login START') 

        # Default known message
        known_message = 'En un lugar de la Mancha, de cuyo nombre no quiero'\
    Severity: Minor
    Found in gecoscc/api/help_channel_client.py - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                      return {'ok': False, 'message': 'This client does not exists'}
      Severity: Major
      Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return {'ok': False, 'message': 'This chef node does not exists'}
        Severity: Major
        Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return {'ok': True, 'token': token}
          Severity: Major
          Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return {'ok': False,
            Severity: Major
            Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return {'ok': False,
              Severity: Major
              Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return {'ok': False,
                Severity: Major
                Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return {'ok': False, 'message': 'Unknown error'}
                  Severity: Major
                  Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return {'ok': False,
                    Severity: Major
                    Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return {'ok': False, 'message': 'Bad secret'}
                      Severity: Major
                      Found in gecoscc/api/help_channel_client.py - About 30 mins to fix

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                                if 'X-Forwarded-For' in self.request.headers:
            remote_addr = self.request.headers['X-Forwarded-For']
            header = 'X-Forwarded-For'
                        Severity: Major
                        Found in gecoscc/api/help_channel_client.py and 3 other locations - About 40 mins to fix
                        gecoscc/api/help_channel_client.py on lines 353..355
                        gecoscc/permissions.py on lines 248..250
                        gecoscc/permissions.py on lines 251..253

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 34.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                                if 'X-Real-IP' in self.request.headers:
            remote_addr = self.request.headers['X-Real-IP']
            header = 'X-Real-IP'
                        Severity: Major
                        Found in gecoscc/api/help_channel_client.py and 3 other locations - About 40 mins to fix
                        gecoscc/api/help_channel_client.py on lines 356..358
                        gecoscc/permissions.py on lines 248..250
                        gecoscc/permissions.py on lines 251..253

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 34.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status