geminabox/geminabox

View on GitHub

Showing 71 of 104 total issues

Class Server has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Server < Sinatra::Base
    enable :static, :methodoverride
    set :public_folder, Geminabox.public_folder
    set :views, Geminabox.views

Severity: Minor
Found in lib/geminabox/server.rb - About 4 hrs to fix

    File server.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Confirmed

    require 'reentrant_flock'
    require 'rubygems/util'
    
    module Geminabox
    
    
    Severity: Minor
    Found in lib/geminabox/server.rb - About 3 hrs to fix

      Method reindex has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

            def reindex(force_rebuild = false)
              fixup_bundler_rubygems!
              force_rebuild = true unless Geminabox.incremental_updates
              if force_rebuild
                indexer.generate_index
      Severity: Minor
      Found in lib/geminabox/server.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method <=> has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Confirmed

          def <=>(other)
            sort = other.name <=> name
            sort = version <=>  other.version       if sort.zero?
            sort = (other.ruby? && !ruby?) ? 1 : -1 if sort.zero? && ruby? != other.ruby?
            sort = other.platform <=> platform      if sort.zero?
      Severity: Minor
      Found in lib/geminabox/gem_version.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Line length
      Open

      Hook authors are responsible to perform any action non-blocking/async to avoid HTTP timeout.
      Severity: Info
      Found in README.md by markdownlint

      MD013 - Line length

      Tags: line_length

      Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

      This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

      This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

      You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

      Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

      Code block style
      Confirmed

          Usage: gem inabox GEM [options]
      Severity: Info
      Found in README.md by markdownlint

      dynamic constant assignment
      Open

            IGNORE_DEPENDENCIES = 0..-2
      Severity: Minor
      Found in lib/geminabox/gem_list_merge.rb by rubymotion

      module definition in method body
      Open

          module CombineLocalAndRemoteGemVersions
      Severity: Minor
      Found in lib/geminabox/gem_list_merge.rb by rubymotion

      Line length
      Open

          # Use Rack::Protection to prevent XSS and CSRF vulnerability if your geminabox server is open public.
      Severity: Info
      Found in README.md by markdownlint

      MD013 - Line length

      Tags: line_length

      Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

      This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

      This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

      You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

      Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

      Code block style
      Confirmed

          RUBYGEMS_PROXY=true rackup
      Severity: Info
      Found in README.md by markdownlint

      Code block style
      Confirmed

          Geminabox.rubygems_proxy = true
      Severity: Info
      Found in README.md by markdownlint

      Multiple top level headers in the same document
      Confirmed

      # 1.0.0 - 1.4.1
      Severity: Info
      Found in CHANGELOG.md by markdownlint

      MD025 - Multiple top level headers in the same document

      Tags: headers

      Aliases: single-h1

      Parameters: level (number; default 1)

      This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

      # Top level header
      
      # Another top level header

      To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

      # Title
      
      ## Header
      
      ## Another header

      Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

      Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

      Inconsistent indentation for list items at the same level
      Confirmed

        - The title will be used for changelog.
      Severity: Info
      Found in CONTRIBUTING.md by markdownlint

      MD005 - Inconsistent indentation for list items at the same level

      Tags: bullet, ul, indentation

      Aliases: list-indent

      This rule is triggered when list items are parsed as being at the same level, but don't have the same indentation:

      * Item 1
          * Nested Item 1
          * Nested Item 2
         * A misaligned item

      Usually this rule will be triggered because of a typo. Correct the indentation for the list to fix it:

      * Item 1
        * Nested Item 1
        * Nested Item 2
        * Nested Item 3

      Pass array contents as separate arguments.
      Open

          public_folder:                  File.join(File.dirname(__FILE__), *%w[.. public]),
      Severity: Minor
      Found in lib/geminabox.rb by rubocop

      This cop checks for unneeded usages of splat expansion

      Example:

      # bad
      
      a = *[1, 2, 3]
      a = *'a'
      a = *1
      
      begin
        foo
      rescue *[StandardError, ApplicationError]
        bar
      end
      
      case foo
      when *[1, 2, 3]
        bar
      else
        baz
      end

      Example:

      # good
      
      c = [1, 2, 3]
      a = *c
      a, b = *c
      a, *b = *c
      a = *1..10
      a = ['a']
      
      begin
        foo
      rescue StandardError, ApplicationError
        bar
      end
      
      case foo
      when *[1, 2, 3]
        bar
      else
        baz
      end

      Do not prefix writer method names with set_.
      Open

          def set_auth(*args)
      Severity: Minor
      Found in lib/geminabox/http_adapter.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Multiple top level headers in the same document
      Confirmed

      # 0.13.x
      Severity: Info
      Found in CHANGELOG.md by markdownlint

      MD025 - Multiple top level headers in the same document

      Tags: headers

      Aliases: single-h1

      Parameters: level (number; default 1)

      This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

      # Top level header
      
      # Another top level header

      To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

      # Title
      
      ## Header
      
      ## Another header

      Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

      Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

      Unordered list indentation
      Confirmed

         - Please add your comments to the issue if you find.
      Severity: Info
      Found in CONTRIBUTING.md by markdownlint

      MD007 - Unordered list indentation

      Tags: bullet, ul, indentation

      Aliases: ul-indent

      Parameters: indent (number; default 2)

      This rule is triggered when list items are not indented by the configured number of spaces (default: 2).

      Example:

      * List item
         * Nested list item indented by 3 spaces

      Corrected Example:

      * List item
        * Nested list item indented by 2 spaces

      Rationale (2 space indent): indenting by 2 spaces allows the content of a nested list to be in line with the start of the content of the parent list when a single space is used after the list marker.

      Rationale (4 space indent): Same indent as code blocks, simpler for editors to implement. See http://www.cirosantilli.com/markdown-styleguide/#indented-lists for more information.

      In addition, this is a compatibility issue with multi-markdown parsers, which require a 4 space indents. See http://support.markedapp.com/discussions/problems/21-sub-lists-not-indenting for a description of the problem.

      Do not suppress exceptions.
      Open

            rescue
      Severity: Minor
      Found in lib/geminabox/server.rb by rubocop

      This cop checks for rescue blocks with no body.

      Example:

      # bad
      
      def some_method
        do_something
      rescue
        # do nothing
      end

      Example:

      # bad
      
      begin
        do_something
      rescue
        # do nothing
      end

      Example:

      # good
      
      def some_method
        do_something
      rescue
        handle_exception
      end

      Example:

      # good
      
      begin
        do_something
      rescue
        handle_exception
      end

      Bare URL used
      Confirmed

      - https://github.com/geminabox/geminabox/releases/tag/v1.2.0
      Severity: Info
      Found in CHANGELOG.md by markdownlint

      MD034 - Bare URL used

      Tags: links, url

      Aliases: no-bare-urls

      This rule is triggered whenever a URL is given that isn't surrounded by angle brackets:

      For more information, see http://www.example.com/.

      To fix this, add angle brackets around the URL:

      For more information, see <http:></http:>.

      Rationale: Without angle brackets, the URL isn't converted into a link in many markdown parsers.

      Note: if you do want a bare URL without it being converted into a link, enclose it in a code block, otherwise in some markdown parsers it will be converted:

      `http://www.example.com`

      Line length
      Open

      Start your gem server with 'rackup' to run WEBrick or hook up the config.ru as you normally would ([passenger](https://www.phusionpassenger.com/), [thin](http://code.macournoyer.com/thin/), [unicorn](https://bogomips.org/unicorn/), whatever floats your boat).
      Severity: Info
      Found in README.md by markdownlint

      MD013 - Line length

      Tags: line_length

      Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

      This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

      This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

      You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

      Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

      Severity
      Category
      Status
      Source
      Language