generationtux/brizo

View on GitHub
app/handlers/api/environments.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function EnvironmentDeploy has 7 return statements (exceeds 4 allowed).
Open

func EnvironmentDeploy(w http.ResponseWriter, r *http.Request) {
    var deployForm struct {
        // id of the Version we want to deploy
        VersionUUID string `json:"version_uuid"`
    }
Severity: Major
Found in app/handlers/api/environments.go - About 45 mins to fix

    Function EnvironmentPromote has 7 return statements (exceeds 4 allowed).
    Open

    func EnvironmentPromote(w http.ResponseWriter, r *http.Request) {
        db, err := database.Connect()
        defer db.Close()
        if err != nil {
            jsonutil.DatabaseConnectError().Render(w)
    Severity: Major
    Found in app/handlers/api/environments.go - About 45 mins to fix

      Function EnvironmentCreate has 5 return statements (exceeds 4 allowed).
      Open

      func EnvironmentCreate(w http.ResponseWriter, r *http.Request) {
          client, err := kube.New()
          if err != nil {
              jsonutil.KubeClientConnectionError().Render(w)
              return
      Severity: Major
      Found in app/handlers/api/environments.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func EnvironmentShow(w http.ResponseWriter, r *http.Request) {
            db, err := database.Connect()
            defer db.Close()
            if err != nil {
                jsonutil.DatabaseConnectError().Render(w)
        Severity: Major
        Found in app/handlers/api/environments.go and 1 other location - About 2 hrs to fix
        app/handlers/api/environment_config.go on lines 15..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 203.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func EnvironmentIndex(w http.ResponseWriter, r *http.Request) {
            db, err := database.Connect()
            defer db.Close()
            if err != nil {
                jsonutil.DatabaseConnectError().Render(w)
        Severity: Major
        Found in app/handlers/api/environments.go and 1 other location - About 1 hr to fix
        app/handlers/api/auth.go on lines 75..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status