Sign upLogin

gentoo/elivepatch-client

View on GitHub
Star

Showing 164 of 164 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        security_file = open(self.repo_dir+str(major_version)+"."+str(minor_version)+
                             "/"+str(major_version)+"."+str(minor_version)+"_security.txt", "r")
Severity: Major
Found in src/elivepatch_client/security.py and 1 other location - About 4 hrs to fix
src/elivepatch_client/security.py on lines 32..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        security_file = open(self.repo_dir+str(major_version)+"."+str(minor_version)+
                             "/"+str(major_version)+"."+str(minor_version)+"_security.txt", "r")
Severity: Major
Found in src/elivepatch_client/security.py and 1 other location - About 4 hrs to fix
src/elivepatch_client/security.py on lines 76..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function dispatch has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def dispatch(self, config):
        log.debug(str(config))
        if config.cve:
            patch_manager = patch.ManaGer()
            applied_patches_list = patch_manager.list(config.kernel_version)
Severity: Minor
Found in src/elivepatch_client/cli.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function list has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def list(self, kernel_version):
        """
        Listing incremental patches
        :param kernel_version: String  with kernel version
        :return: list of incremental patch
Severity: Minor
Found in src/elivepatch_client/patch.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cve_git_id has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def cve_git_id(self, kernel_version):
        major_version, minor_version, revision_version = kernel_version.split('.')
        print(major_version, minor_version, revision_version)
        security_file = open(self.repo_dir+str(major_version)+"."+str(minor_version)+
                             "/"+str(major_version)+"."+str(minor_version)+"_security.txt", "r")
Severity: Minor
Found in src/elivepatch_client/security.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cve_id has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def cve_id(self, major_version, minor_version, revision_version):
        security_file = open(self.repo_dir+str(major_version)+"."+str(minor_version)+
                             "/"+str(major_version)+"."+str(minor_version)+"_security.txt", "r")

        git_security_id = []
Severity: Minor
Found in src/elivepatch_client/security.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if filename.endswith('.patch'):
                            log.notice('dirpath: '+str(dirpath),'filename: '+str(filename))
                            incremental_patch_fullpath = os.path.join(dirpath, filename)
                            log.notice(incremental_patch_fullpath)
                            patch_filename.append(incremental_patch_fullpath)
Severity: Major
Found in src/elivepatch_client/patch.py - About 45 mins to fix

Function get_livepatch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def get_livepatch(self, patch_folder):
        """
        Save the patch in the incremental patches folder and install the livepatch
        :param patch_folder: Main patch that will be saved in the incremental patches folder.
        """
Severity: Minor
Found in src/elivepatch_client/restful.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function livepatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def livepatch(url, kernel_version, config, main_patch, incremental_patch_names_list):
Severity: Minor
Found in src/elivepatch_client/cli.py - About 35 mins to fix

Line too long (80 > 79 characters)
Open

#===============================================================================
Severity: Minor
Found in src/elivepatch_client/__main__.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (89 > 79 characters)
Open

        parser.add_argument("-a","--kernel_version", help="set kernel version manually.")
Severity: Minor
Found in src/elivepatch_client/argsparser.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Missing whitespace after ','
Open

        parser.add_argument("-a","--kernel_version", help="set kernel version manually.")
Severity: Minor
Found in src/elivepatch_client/argsparser.py by pep8

Each comma, semicolon or colon should be followed by whitespace.

Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

Missing whitespace after ','
Open

        parser.add_argument("-d","--debug", help="set the debug option.")
Severity: Minor
Found in src/elivepatch_client/argsparser.py by pep8

Each comma, semicolon or colon should be followed by whitespace.

Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

Line too long (95 > 79 characters)
Open

    :param incremental_patch_names_list: list of patch path that are already used in the kernel
Severity: Minor
Found in src/elivepatch_client/cli.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (89 > 79 characters)
Open

                            super(elivepatchLogger, self)._log(level, line, (), **kwargs)
Severity: Minor
Found in src/elivepatch_client/log.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Over-indented
Open

                            super(elivepatchLogger, self)._log(level, line, (), **kwargs)
Severity: Minor
Found in src/elivepatch_client/log.py by pep8

Use indent_size (PEP8 says 4) spaces per indentation level.

For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

Over-indented
Open

        """Mark bad messages with colors automatically"""
Severity: Minor
Found in src/elivepatch_client/log.py by pep8

Use indent_size (PEP8 says 4) spaces per indentation level.

For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

Missing whitespace after ','
Open

                            log.notice('dirpath: '+str(dirpath),'filename: '+str(filename))
Severity: Minor
Found in src/elivepatch_client/patch.py by pep8

Each comma, semicolon or colon should be followed by whitespace.

Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

Missing whitespace around operator
Open

                    b= BytesIO(r.content)
Severity: Minor
Found in src/elivepatch_client/restful.py by pep8

Surround operators with a single space on either side.

- Always surround these binary operators with a single space on
  either side: assignment (=), augmented assignment (+=, -= etc.),
  comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
  Booleans (and, or, not).

- If operators with different priorities are used, consider adding
  whitespace around the operators with the lowest priorities.

Okay: i = i + 1
Okay: submitted += 1
Okay: x = x * 2 - 1
Okay: hypot2 = x * x + y * y
Okay: c = (a + b) * (a - b)
Okay: foo(bar, key='word', *args, **kwargs)
Okay: alpha[:-i]

E225: i=i+1
E225: submitted +=1
E225: x = x /2 - 1
E225: z = x **y
E225: z = 1and 1
E226: c = (a+b) * (a-b)
E226: hypot2 = x*x + y*y
E227: c = a|b
E228: msg = fmt%(errno, errmsg)

Do not use bare 'except'
Open

        except:
Severity: Minor
Found in src/elivepatch_client/restful.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:
Severity
Category
Status
Source
Language