georgebellos/real_estate

View on GitHub

Showing 829 of 829 total issues

Color literals like rgb(92, 92, 92) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  background: none repeat scroll 0% 0% rgb(92, 92, 92);

Line is too long. [87/80]
Open

    @favs_quicklist = current_user.favorites.includes(:images).limit(4) if current_user

Space between { and | missing.
Open

       @properties = session[:compare_list].map{|id| Property.find_by_id(id) }

Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

Example: EnforcedStyle: space (default)

# The `space` style enforces that block braces have
# surrounding space.

# bad
some_array.each {puts e}

# good
some_array.each { puts e }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that block braces don't
# have surrounding space.

# bad
some_array.each { puts e }

# good
some_array.each {puts e}

Example: EnforcedStyleForEmptyBraces: no_space (default)

# The `no_space` EnforcedStyleForEmptyBraces style enforces that
# block braces don't have a space in between when empty.

# bad
some_array.each {   }
some_array.each {  }
some_array.each { }

# good
some_array.each {}

Example: EnforcedStyleForEmptyBraces: space

# The `space` EnforcedStyleForEmptyBraces style enforces that
# block braces have at least a spece in between when empty.

# bad
some_array.each {}

# good
some_array.each { }
some_array.each {  }
some_array.each {   }

Example: SpaceBeforeBlockParameters: true (default)

# The SpaceBeforeBlockParameters style set to `true` enforces that
# there is a space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each {|n| n * 2 }

# good
[1, 2, 3].each { |n| n * 2 }

Example: SpaceBeforeBlockParameters: true

# The SpaceBeforeBlockParameters style set to `false` enforces that
# there is no space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each { |n| n * 2 }

# good
[1, 2, 3].each {|n| n * 2 }

Avoid using id selectors
Open

  #contact li {

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/uploaders/picture_uploader.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Color literals like black should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    background-color: black;

Line is too long. [81/80]
Open

  # Avoid using model.id or version_name here, see uploader/store.rb for details.
Severity: Minor
Found in app/uploaders/picture_uploader.rb by rubocop

Rule declaration should be followed by an empty line
Open

   }

Unnecessary utf-8 encoding comment.
Open

# encoding: utf-8
Severity: Minor
Found in app/uploaders/picture_uploader.rb by rubocop

0px should be written without units as 0
Open

     margin: 0px 0px 10px 13px;

Line is too long. [103/80]
Open

      raise ArgumentError, 'Range unspecified. Specify the :within, :maximum, :minimum, or :is option.'
Severity: Minor
Found in lib/file_size_validator.rb by rubocop

Colon after property should be followed by one space
Open

    font-weight:100;

Use %i or %I for an array of symbols.
Open

gem 'rspec-rails', '~> 2.13.2', group: [:development, :test]
Severity: Minor
Found in Gemfile by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Shorthand form for property margin should be written more concisely as 5px auto instead of 5px auto 5px auto
Open

    margin: 5px auto 5px auto;

Prefer single quoted strings
Open

@import "bootstrap/variables";

Color literals like rgba(0, 0, 0, 0.18) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  border-bottom: 1px solid rgba(0, 0, 0, 0.18);

Prefer single quoted strings
Open

@import "bootstrap/button-groups";

Prefer single quoted strings
Open

@import "bootstrap/navbar";

Prefer single quoted strings
Open

@import "bootstrap/progress-bars";

Color white should be written in hexadecimal form as #ffffff
Open

  background: white;
Severity
Category
Status
Source
Language