georgebellos/real_estate

View on GitHub

Showing 829 of 829 total issues

Prefer single quoted strings
Open

@import "globals/colors";

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  desc "Clean out temp CarrierWave files"
Severity: Minor
Found in lib/tasks/carrierwave.rake by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Color literals like rgb(42, 43, 43) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    color: rgb(42, 43, 43);

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem pry-rails should appear before rb-inotify.
Open

  gem 'pry-rails', '~> 0.3.0'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

0px should be written without units as 0
Open

    padding: 0px 5px;

Shorthand form for property margin should be written more concisely as 10px auto 30px instead of 10px auto 30px auto
Open

  margin: 10px auto 30px auto;

Color white should be written in hexadecimal form as #ffffff
Open

$body-bg: white;

Avoid vendor prefixes.
Open

  -webkit-box-sizing: border-box;

0px should be written without units as 0
Open

  @include box-shadow(0px 1px 6px #bbb);

Color literals like #ccc should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    border-color: #ccc #ccc #999 #ccc;

Color literals like #bbb should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  @include box-shadow(0px 1px 6px #bbb);

Color literals like #676767 should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  color: #676767;

0.5 should be written without a leading zero as .5
Open

    -webkit-box-shadow: rgba(64, 64, 64, 0.5) 0 2px 5px;

Use // comments everywhere
Open

/***  Mixins  ***/

Use // comments everywhere
Open

/***  Bootstrap Theming  ***/

0.5 should be written without a leading zero as .5
Open

    -moz-box-shadow: rgba(64, 64, 64, 0.5) 0 2px 5px;

Use // comments everywhere
Open

/***  Compass  ***/

!important should not be used
Open

  height: auto !important;

Selector gmaps4rails_map should be written in lowercase with hyphens
Open

  .gmaps4rails_map {

Color black should be written in hexadecimal form as #000000
Open

    background-color: black;
Severity
Category
Status
Source
Language