Sign upLogin

georgebellos/real_estate

View on GitHub
Star

Showing 829 of 829 total issues

Prefer single quoted strings
Open

@import "bootstrap/buttons";
Severity: Minor
Found in app/assets/stylesheets/globals/all.css.scss by scss-lint

Color literals like rgb(185, 188, 194) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  border: 1px solid rgb(185, 188, 194);
Severity: Minor
Found in app/assets/stylesheets/sections/properties.css.scss by scss-lint

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    if controller.action_name == "buy" || controller.action_name == "rent"
Severity: Minor
Found in app/helpers/properties_helper.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Properties should be ordered float, margin, margin-right
Open

  margin: 7px;
Severity: Minor
Found in app/assets/stylesheets/sections/properties.css.scss by scss-lint

0.5 should be written without a leading zero as .5
Open

    -moz-box-shadow: rgba(64, 64, 64, 0.5) 0 2px 5px;
Severity: Minor
Found in app/assets/stylesheets/sections/property.scss by scss-lint

Prefer single quoted strings
Open

@import "bootstrap/modals";
Severity: Minor
Found in app/assets/stylesheets/globals/all.css.scss by scss-lint

Color white should be written in hexadecimal form as #ffffff
Open

    background: white;
Severity: Minor
Found in app/assets/stylesheets/sections/property.scss by scss-lint

Space inside string interpolation detected.
Open

      notice: "You unfavorited #{ @property.category } at #{ @property.street }"
Severity: Minor
Found in app/controllers/favorites_controller.rb by rubocop

This cop checks for whitespace within string interpolations.

Example: EnforcedStyle: no_space (default)

# bad
   var = "This is the #{ space } example"

# good
   var = "This is the #{no_space} example"

Example: EnforcedStyle: space

# bad
   var = "This is the #{no_space} example"

# good
   var = "This is the #{ space } example"

Color green should be written in hexadecimal form as #008000
Open

  color: green;
Severity: Minor
Found in app/assets/stylesheets/sections/compare_list.css.scss by scss-lint

Properties should be ordered height, margin-left, margin-top, width
Open

    margin-top: 10px;
Severity: Minor
Found in app/assets/stylesheets/sections/sidebar.css.scss by scss-lint

Shorthand form for property padding should be written more concisely as 20px 0px 30px instead of 20px 0px 30px 0px
Open

    padding: 20px 0px 30px 0px;
Severity: Minor
Found in app/assets/stylesheets/sections/footer.css.scss by scss-lint

Line is too long. [84/80]
Open

  before_filter :authenticate_user!, only: [:new, :create, :edit, :update, :destroy]
Severity: Minor
Found in app/controllers/properties_controller.rb by rubocop

Each selector in a comma sequence should be on its own single line
Open

#search-query-head span, #search-filter-head span {
Severity: Minor
Found in app/assets/stylesheets/sections/sidebar.css.scss by scss-lint

Line should be indented 2 spaces, but was indented 3 spaces
Open

   #search_query {
Severity: Minor
Found in app/assets/stylesheets/sections/landing_page.css.scss by scss-lint

Nesting should be no greater than 3, but was 4
Open

      &:hover, &:active {
Severity: Minor
Found in app/assets/stylesheets/sections/sidebar.css.scss by scss-lint

Align the parameters of a method call if they span more than one line.
Open

        notice: 'Property listing is already on the compare list'
Severity: Minor
Found in app/controllers/compares_controller.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Colon after property should be followed by one space
Open

    display:inline-block;
Severity: Minor
Found in app/assets/stylesheets/sections/landing_page.css.scss by scss-lint

Align the parameters of a method call if they span more than one line.
Open

     notice: 'You should add a listing to compare list'
Severity: Minor
Found in app/controllers/compares_controller.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Avoid qualifying class selectors with an element.
Open

  input.btn {
Severity: Minor
Found in app/assets/stylesheets/shared/forms.scss by scss-lint

Color literals like rgba(255, 255, 255, 0.7) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    background: none repeat scroll 0% 0% rgba(255, 255, 255, 0.7);
Severity: Minor
Found in app/assets/stylesheets/sections/landing_page.css.scss by scss-lint
Severity
Category
Status
Source
Language