gerencianet/gn-api-sdk-ruby

View on GitHub

Showing 70 of 70 total issues

Freeze mutable objects assigned to constants.
Open

    OK = "200 OK"
Severity: Minor
Found in lib/gerencianet/status.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Trailing whitespace detected.
Open

          end)        
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

Trailing whitespace detected.
Open

  
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

Use Hash#key? instead of Hash#has_key?.
Open

      if (@options.has_key?(:pix_cert))
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

This cop (by default) checks for uses of methods Hash#haskey? and Hash#hasvalue? where it enforces Hash#key? and Hash#value? It is configurable to enforce the inverse, using verbose method names also.

Example: EnforcedStyle: short (default)

# bad Hash#haskey? Hash#hasvalue?

# good Hash#key? Hash#value?

Example: EnforcedStyle: verbose

# bad Hash#key? Hash#value?

# good Hash#haskey? Hash#hasvalue?

Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Open

        .headers(headers)
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

Don't use parentheses around a method call.
Open

      if (@options.has_key?(:pix_cert))
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Extra empty line detected at method body end.
Open


    end
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

This cops checks if empty lines exist around the bodies of methods.

Example:

# good

def foo
  # ...
end

# bad

def bar

  # ...

end

Trailing whitespace detected.
Open

       
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

Don't use parentheses around the condition of an if.
Open

      if (@options.has_key?(:pix_cert))
Severity: Minor
Found in lib/gerencianet/endpoints.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency listen should appear before rubocop.
Open

  spec.add_development_dependency "listen", "~> 3.0.4", ">= 3.0.4"
Severity: Minor
Found in gerencianet.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'
Severity
Category
Status
Source
Language