getindata/data-pipelines-cli

View on GitHub

Showing 66 of 76 total issues

Function generate_databricks_job_command has 16 arguments (exceeds 4 allowed). Consider refactoring.
Open

def generate_databricks_job_command(
Severity: Major
Found in data_pipelines_cli/cli_commands/generate/databricks_job.py - About 2 hrs to fix

    Missing module docstring
    Open

    import pathlib

    Used when a module has no docstring.Empty modules do not require a docstring.

    No name 'annotations' in module '__future__'
    Open

    from __future__ import annotations

    Used when a name cannot be found in a module.

    Value 'list' is unsubscriptable
    Open

        task_cluster: list[tuple[str, str]],

    Emitted when a subscripted value doesn't support subscription (i.e. doesn't define getitem method or class_getitem for a class).

    Missing module docstring
    Open

    import json

    Used when a module has no docstring.Empty modules do not require a docstring.

    Variable name f doesn't conform to snake_case naming style
    Open

        with open(pathlib.Path.cwd().joinpath("dbt_project.yml"), "r") as f:

    Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

    Missing function or method docstring
    Open

    )

    Used when a function or method has no docstring.Some special methods like init do not require a docstring.

    Import outside toplevel (docker)
    Open

            import docker

    Used when an import statement is used anywhere other than the module toplevel. Move this import to the top of the file.

    Missing function or method docstring
    Open

        help="Name of the environment",

    Used when a function or method has no docstring.Some special methods like init do not require a docstring.

    Missing class docstring
    Open

    class MacroArgName(TypedDict):

    Used when a class has no docstring.Even an empty class must have a docstring.

    Missing module docstring
    Open

    import pathlib

    Used when a module has no docstring.Empty modules do not require a docstring.

    Missing function or method docstring
    Open

    def generate_group() -> None:

    Used when a function or method has no docstring.Some special methods like init do not require a docstring.

    Too many local variables (16/15)
    Open

    @click.option(

    Used when a function or method has too many local variables.

    Missing module docstring
    Open

    import json

    Used when a module has no docstring.Empty modules do not require a docstring.

    Similar lines in 2 files
    Open

    """data_pipelines_cli module."""
    Severity: Info
    Found in setup.py by pylint

    Indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication. ==datapipelinescli.clicommands.generate.modelyaml:81 ==datapipelinescli.clicommands.generate.sourceyaml:38 outputfile, defaultflowstyle=False, sortkeys=False, ) echoinfo(f`Generated source schema file and saved in {outputpath}`)

    Unnecessary else after return
    Open

            if not overwrite:

    Used in order to highlight an unnecessary block of code following an if containing a return statement. As such, it will warn when it encounters an else following a chain of ifs, all of them containing a return statement.

    Missing module docstring
    Open

    import json

    Used when a module has no docstring.Empty modules do not require a docstring.

    Missing function or method docstring
    Open

    def generate_source_yamls(

    Used when a function or method has no docstring.Some special methods like init do not require a docstring.

    Value 'tuple' is unsubscriptable
    Open

        task_cluster: list[tuple[str, str]],

    Emitted when a subscripted value doesn't support subscription (i.e. doesn't define getitem method or class_getitem for a class).

    Missing module docstring
    Open

    import pathlib

    Used when a module has no docstring.Empty modules do not require a docstring.

    Severity
    Category
    Status
    Source
    Language