getlackey/lackey-cms

View on GitHub

Showing 527 of 527 total issues

File index.js has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* jslint esnext:true, node:true */
/* globals LACKEY_PATH */
'use strict';

/*
Severity: Minor
Found in modules/core/server/models/template/index.js - About 2 hrs to fix

    File index.js has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint no-underscore-dangle:0, no-process-exit:0 */
    /* jslint node:true, esnext:true */
    /* globals LACKEY_PATH */
    'use strict';
    
    
    Severity: Minor
    Found in lib/utils/index.js - About 2 hrs to fix

      Function exports has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          .then((Model, Crud) => {
              class RedirectCtrl extends Crud {
      
                  static get model() {
                      return this._overriden('model', Model);
      Severity: Major
      Found in modules/cms/server/controllers/redirect.js - About 2 hrs to fix

        Function alternative has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            alternative() {
                let self = this;
                return template
                    .redraw(lackey.hook('sources', this.node), this.options)
                    .then(() => {
        Severity: Major
        Found in modules/cms/client/js/manager/gallery.ui.js - About 2 hrs to fix

          Function exports has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              .then((FlyWeight) => {
          
                  SCli.debug(__MODULE_NAME, 'READY');
          
                  class RedirectModel extends Model {
          Severity: Major
          Found in modules/core/server/models/redirect/index.js - About 2 hrs to fix

            Function exports has 69 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                .then((ObjectionWrapper, User) => {
                    SCli.debug(__MODULE_NAME, 'READY');
            
                    class SessionModel extends Model {
                        static get tableName() {
            Severity: Major
            Found in modules/core/server/models/session/index.js - About 2 hrs to fix

              Function exports has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = (dust) => {
              
                dust.helpers.taxonomy = function (chunk, context, bodies, params) {
                  let data = context.get('data'),
                    name = params.name,
              Severity: Minor
              Found in modules/cms/server/lib/dust/taxonomy.js - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      }, (error) => {
                        SCli.debug('lackey-cms/modules/cms/serer/lib/dust/embed', 'Error', route, template);
                        if (bodies.error) {
                          injectedChunk.render(bodies.error, data.push({
                            error: error
              Severity: Major
              Found in modules/cms/server/lib/dust/embed.js and 1 other location - About 2 hrs to fix
              modules/cms/server/lib/dust/embed.js on lines 70..80

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                            if (err) {
                              SCli.debug('lackey-cms/modules/cms/serer/lib/dust/embed', 'Error', route, template);
                              if (bodies.error) {
                                injectedChunk.render(bodies.error, data.push({
                                  error: err
              Severity: Major
              Found in modules/cms/server/lib/dust/embed.js and 1 other location - About 2 hrs to fix
              modules/cms/server/lib/dust/embed.js on lines 102..112

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function buildUI has 68 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  buildUI() {
                      let self = this;
                      return template
                          .render('cms/cms/gallery', this.options || {})
                          .then(nodes => {
              Severity: Major
              Found in modules/cms/client/js/manager/gallery.ui.js - About 2 hrs to fix

                Function getRESTQuery has 67 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    req.getRESTQuery = (truncate) => {
                
                        let result = {
                            query: {},
                            populate: null,
                Severity: Major
                Found in lib/server/init/rest.js - About 2 hrs to fix

                  Table has 24 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Table {
                  
                      constructor(element) {
                          var
                              self = this;
                  Severity: Minor
                  Found in modules/core/client/js/table.js - About 2 hrs to fix

                    Function exports has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        .then((User, ObjectionWrapper) => {
                    
                            SCli.debug(__MODULE_NAME, 'READY');
                    
                            class ActivityLogModel extends Model {
                    Severity: Major
                    Found in modules/core/server/models/activity-log/index.js - About 2 hrs to fix

                      Function table has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          static table(model, req, res) {
                      
                              let restParams = req.getRESTQuery(true),
                                  isExport = req.__resFormat === 'xlsx',
                                  self = this,
                      Severity: Major
                      Found in modules/core/server/controllers/crud.injection.js - About 2 hrs to fix

                        Function exports has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        module.exports = (data) => {
                            return require('./index')
                                .then((content) => {
                                    Content = content;
                                    templateGenerator = require('../template/generator');
                        Severity: Major
                        Found in modules/core/server/models/content/generator.js - About 2 hrs to fix

                          Function video_embed has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function video_embed(md, options) {
                            function video_return(state, silent) {
                              var serviceEnd,
                                serviceStart,
                                token,
                          Severity: Minor
                          Found in modules/cms/shared/video/viewmode.js - About 2 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function exports has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                          Open

                              .then((ContentModel, Taxonomy, TaxonomyType, Template, User, Preview) => {
                          
                                  class PageController {
                          
                                      static preview(req, res, next) {
                          Severity: Minor
                          Found in modules/cms/server/controllers/page.js - About 2 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function media has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            dust.helpers.media = function (chunk, context, bodies, params) {
                          
                              let editMode = params.editMode,
                                content = params.content,
                                id = content ? content.id + '' : '',
                          Severity: Major
                          Found in modules/cms/server/lib/dust/media.js - About 2 hrs to fix

                            Function exports has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            module.exports = function (el) {
                                var root = el || document,
                                    name = lackey.select('input[name="title"]', root)[0],
                                    slug = lackey.select('input[name="slug"]', root)[0];
                            
                            
                            Severity: Major
                            Found in modules/cms/client/js/new-page.js - About 2 hrs to fix

                              File upgrade.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              /* jslint node:true, esnext:true */
                              /* globals LACKEY_PATH, window */
                              'use strict';
                              
                              const
                              Severity: Minor
                              Found in modules/core/server/models/content/upgrade.js - About 2 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language