Sign upLogin

getsentry/raven-python

View on GitHub
Star
raven/versioning.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function fetch_git_sha has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

def fetch_git_sha(path, head=None):
    """
    >>> fetch_git_sha(os.path.dirname(__file__))
    """
    if not head:
Severity: Minor
Found in raven/versioning.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if line and line[:1] not in ('#', '^'):
                        try:
                            revision, ref = line.split(' ', 1)
                        except ValueError:
                            continue
Severity: Major
Found in raven/versioning.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status