Sign upLogin

gfw-api/forest-change-analysis-elastic

View on GitHub
Star
gladanalysis/routes/api/v2/terrai_router.py

Summary

Maintainability
A
1 hr
Test Coverage
D
69%

Function analyze has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def analyze(area=None, geostore=None, iso=None, state=None, dist=None, geojson=None):
Severity: Minor
Found in gladanalysis/routes/api/v2/terrai_router.py - About 45 mins to fix

    Function query_terrai has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def query_terrai():
    """analyze terrai by geostore or geojson"""

    if request.method == 'GET':
        logging.info('[ROUTER]: get Terra I by Geostore')
    Severity: Minor
    Found in gladanalysis/routes/api/v2/terrai_router.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function analyze has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def analyze(area=None, geostore=None, iso=None, state=None, dist=None, geojson=None):
    """Analyze method to execute queries
    This is designed to format the dates of the request, create the sql and download sql queries from
    the dates, retrieve the data from the queries and send the data to a formatter service to format
    the API response.
    Severity: Minor
    Found in gladanalysis/routes/api/v2/terrai_router.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status