gfw-api/forest-change-analysis-elastic

View on GitHub
gladanalysis/validators.py

Summary

Maintainability
C
1 day
Test Coverage
D
62%

Function validate_agg has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

def validate_agg(func):
    """validate aggregate_by argument"""

    @wraps(func)
    def wrapper(*args, **kwargs):
Severity: Minor
Found in gladanalysis/validators.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_period has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

def validate_period(minYear):
    today = datetime.datetime.now()
    period = request.args.get('period', None)

    if period:
Severity: Minor
Found in gladanalysis/validators.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_admin has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def validate_admin(func):
    """validate admin arguments"""

    @wraps(func)
    def wrapper(*args, **kwargs):
Severity: Minor
Found in gladanalysis/validators.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_geostore has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def validate_geostore(func):
    """validate geostore argument"""

    @wraps(func)
    def wrapper(*args, **kwargs):
Severity: Minor
Found in gladanalysis/validators.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return func(*args, **kwargs)
Severity: Major
Found in gladanalysis/validators.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return error(status=400, detail='Start date must be less than end date')
    Severity: Major
    Found in gladanalysis/validators.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status