Sign upLogin

gfw-api/gfw-analysis-gee

View on GitHub
Star
gfwanalysis/routes/api/v1/recent_router.py

Summary

Maintainability
F
3 days
Test Coverage
F
35%

Function get_by_geostore has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

def get_by_geostore(lat, lon, start, end, sort_by, bands, bmin, bmax, opacity):
Severity: Major
Found in gfwanalysis/routes/api/v1/recent_router.py - About 1 hr to fix

    Function analyze_recent_data has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def analyze_recent_data(lat, lon, start, end, sort_by, bands, bmin, bmax, opacity):
    Severity: Major
    Found in gfwanalysis/routes/api/v1/recent_router.py - About 1 hr to fix

      Function analyze_recent_thumbs has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def analyze_recent_thumbs(data_array, bands, bmin, bmax, opacity):
      Severity: Minor
      Found in gfwanalysis/routes/api/v1/recent_router.py - About 35 mins to fix

        Function get_by_tile has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def get_by_tile(data_array, bands, bmin, bmax, opacity):
        Severity: Minor
        Found in gfwanalysis/routes/api/v1/recent_router.py - About 35 mins to fix

          Function analyze_recent_tiles has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def analyze_recent_tiles(data_array, bands, bmin, bmax, opacity):
          Severity: Minor
          Found in gfwanalysis/routes/api/v1/recent_router.py - About 35 mins to fix

            Function get_by_thumb has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def get_by_thumb(data_array, bands, bmin, bmax, opacity):
            Severity: Minor
            Found in gfwanalysis/routes/api/v1/recent_router.py - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              def analyze_recent_thumbs(data_array, bands, bmin, bmax, opacity):
    """Takes an array of JSON objects with a 'source' key for each tile url
    to be returned. Returns an array of 'source' names and 'thumb_url' values.
    """
    loop = asyncio.new_event_loop()
              Severity: Major
              Found in gfwanalysis/routes/api/v1/recent_router.py and 1 other location - About 1 day to fix
              gfwanalysis/routes/api/v1/recent_router.py on lines 46..62

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 141.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              def analyze_recent_tiles(data_array, bands, bmin, bmax, opacity):
    """Takes an array of JSON objects with a 'source' key for each tile url
    to be returned. Returns an array of 'source' names and 'tile_url' values.
    """
              Severity: Major
              Found in gfwanalysis/routes/api/v1/recent_router.py and 1 other location - About 1 day to fix
              gfwanalysis/routes/api/v1/recent_router.py on lines 65..79

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 141.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              @recent_tiles_endpoints_v1.route('/thumbs', strict_slashes=False, methods=['POST'])
@get_recent_thumbs
def get_by_thumb(data_array, bands, bmin, bmax, opacity):
    """Analyze by geostore"""
    logging.info('[ROUTER]: Getting thumb url(s) for tiles for Recent Sentinel Images')
              Severity: Major
              Found in gfwanalysis/routes/api/v1/recent_router.py and 1 other location - About 3 hrs to fix
              gfwanalysis/routes/api/v1/recent_router.py on lines 92..98

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              @recent_tiles_endpoints_v1.route('/tiles', strict_slashes=False, methods=['POST'])
@get_recent_tiles
def get_by_tile(data_array, bands, bmin, bmax, opacity):
    """Analyze by geostore"""
    logging.info('[ROUTER]: Getting tile url(s) for tiles for Recent Sentinel Images')
              Severity: Major
              Found in gfwanalysis/routes/api/v1/recent_router.py and 1 other location - About 3 hrs to fix
              gfwanalysis/routes/api/v1/recent_router.py on lines 101..107

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status