gfw-api/gfw-imazon-alerts-api

View on GitHub
src/services/cartoDBServiceV2.ts

Summary

Maintainability
F
1 wk
Test Coverage

File cartoDBServiceV2.ts has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import config from 'config';
import logger from 'logger';
import Mustache from 'mustache';
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
Severity: Minor
Found in src/services/cartoDBServiceV2.ts - About 5 hrs to fix

    Function getUse has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async getUse(useTable: string, id: string, alertQuery: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any>> {
            logger.debug('Obtaining use with id %s', id);
            const periods: string[] = period.split(',');
            const params: Record<string, any> = {
                useTable,
    Severity: Minor
    Found in src/services/cartoDBServiceV2.ts - About 1 hr to fix

      Function getAdm0 has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async getAdm0(iso: string, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
              logger.debug('Obtaining national of iso %s', iso);
              const gid: Record<string, any> = routeToGid(iso);
              const simplify: number = getSimplify(iso);
              const periods: string[] = period.split(',');
      Severity: Minor
      Found in src/services/cartoDBServiceV2.ts - About 1 hr to fix

        Function getWdpa has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async getWdpa(wdpaid: string, alertQuery: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any>> {
                logger.debug('Obtaining wpda of id %s', wdpaid);
                const periods: string[] = period.split(',');
                const params: Record<string, any> = {
                    wdpaid,
        Severity: Minor
        Found in src/services/cartoDBServiceV2.ts - About 1 hr to fix

          Function getAdm2 has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              async getAdm2(iso: string, id1: string, id2: string, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
                  logger.debug('Obtaining regional data', iso, id1, id2);
                  const gid: Record<string, any> = routeToGid(iso, id1, id2);
                  const simplify: number = getSimplify(iso) / 100;
                  const periods: string[] = period.split(',');
          Severity: Minor
          Found in src/services/cartoDBServiceV2.ts - About 1 hr to fix

            Function getAdm1 has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                async getAdm1(iso: string, id1: string, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
                    logger.debug('Obtaining subnational of iso %s and id1', iso, id1);
                    const gid: Record<string, any> = routeToGid(iso, id1);
                    const simplify: number = getSimplify(iso) / 100;
                    const periods: string[] = period.split(',');
            Severity: Minor
            Found in src/services/cartoDBServiceV2.ts - About 1 hr to fix

              Function getAdm0 has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  async getAdm0(iso: string, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
                      logger.debug('Obtaining national of iso %s', iso);
                      const gid: Record<string, any> = routeToGid(iso);
                      const simplify: number = getSimplify(iso);
                      const periods: string[] = period.split(',');
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getWdpa has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  async getWdpa(wdpaid: string, alertQuery: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any>> {
                      logger.debug('Obtaining wpda of id %s', wdpaid);
                      const periods: string[] = period.split(',');
                      const params: Record<string, any> = {
                          wdpaid,
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getUse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  async getUse(useTable: string, id: string, alertQuery: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any>> {
                      logger.debug('Obtaining use with id %s', id);
                      const periods: string[] = period.split(',');
                      const params: Record<string, any> = {
                          useTable,
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getAdm2 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  async getAdm2(iso: string, id1: string, id2: string, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
                      logger.debug('Obtaining regional data', iso, id1, id2);
                      const gid: Record<string, any> = routeToGid(iso, id1, id2);
                      const simplify: number = getSimplify(iso) / 100;
                      const periods: string[] = period.split(',');
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getAdm1 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  async getAdm1(iso: string, id1: string, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
                      logger.debug('Obtaining subnational of iso %s and id1', iso, id1);
                      const gid: Record<string, any> = routeToGid(iso, id1);
                      const simplify: number = getSimplify(iso) / 100;
                      const periods: string[] = period.split(',');
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getWorld has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  async getWorld(hashGeoStore: string, alertQuery: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any>> {
                      logger.debug('Obtaining world with hashGeoStore %s', hashGeoStore);
              
                      const geostore: Record<string, any> = await GeostoreService.getGeostoreByHash(hashGeoStore, apiKey);
                      if (geostore && geostore.geojson) {
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  async getWorld(hashGeoStore: string, alertQuery: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any>> {
                      logger.debug('Obtaining world with hashGeoStore %s', hashGeoStore);
              
                      const geostore: Record<string, any> = await GeostoreService.getGeostoreByHash(hashGeoStore, apiKey);
                      if (geostore && geostore.geojson) {
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 1 day to fix
              src/services/cartoDBService.ts on lines 271..298

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 346.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  async getWorldWithGeojson(geojson: Record<string, any>, alertQuery: string, period: string = defaultDate()): Promise<Record<string, any>> {
                      logger.debug('Executing query in cartodb with geojson', geojson);
                      const periods: string[] = period.split(',');
                      const params: Record<string, any> = {
                          geojson: JSON.stringify(geojson.features[0].geometry),
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 1 day to fix
              src/services/cartoDBService.ts on lines 300..323

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 304.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const executeThunk = async (client: CartoDB.SQL, sql: string, params: any): Promise<Record<string, any>> => (new Promise((resolve: (value: (PromiseLike<unknown> | unknown)) => void, reject: (reason?: any) => void) => {
                  logger.debug(Mustache.render(sql, params));
                  client.execute(sql, params).done((data: Record<string, any>) => {
                      resolve(data);
                  }).error((error: Error) => {
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 7 hrs to fix
              src/services/cartoDBService.ts on lines 74..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 189.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (data && data.rows && data.rows.length) {
                          result.area_ha = data.rows[0].area_ha;
                          result.value = data.rows.map((el: Record<string, any>) => ({
                              label: el.data_type === 'defor' ? 'deforestation' : 'degraded',
                              value: el.value,
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 6 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 347..357

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (data && data.rows && data.rows.length) {
                          result.area_ha = data.rows[0].area_ha;
                          result.value = data.rows.map((el: Record<string, any>) => ({
                              label: el.data_type === 'defor' ? 'deforestation' : 'degraded',
                              value: el.value,
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 6 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 302..312

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          if (data && data.rows && data.rows.length) {
                              result.area_ha = data.rows[0].area_ha;
                              result.value = data.rows.map((el: Record<string, any>) => ({
                                  label: el.data_type === 'defor' ? 'deforestation' : 'degraded',
                                  value: el.value,
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 4 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 219..227
              src/services/cartoDBServiceV2.ts on lines 263..271

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (data && data.rows && data.rows.length) {
                          result.area_ha = data.rows[0].area_ha;
                          result.value = data.rows.map((el: Record<string, any>) => ({
                              label: el.data_type === 'defor' ? 'deforestation' : 'degraded',
                              value: el.value,
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 4 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 175..183
              src/services/cartoDBServiceV2.ts on lines 219..227

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (data && data.rows && data.rows.length) {
                          result.area_ha = data.rows[0].area_ha;
                          result.value = data.rows.map((el: Record<string, any>) => ({
                              label: el.data_type === 'defor' ? 'deforestation' : 'degraded',
                              value: el.value,
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 4 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 175..183
              src/services/cartoDBServiceV2.ts on lines 263..271

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (areas.rows && areas.rows.length > 0) {
                          const areaHa: any = areas.rows && areas.rows[0] || null;
                          result.area_ha = areaHa.area_ha;
                          result.period = period;
                          result.value = [];
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 3 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 359..365

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (areas.rows && areas.rows.length > 0) {
                          const areaHa: any = areas.rows && areas.rows[0] || null;
                          result.area_ha = areaHa.area_ha;
                          result.period = period;
                          result.value = [];
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 3 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 315..321

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const getToday = (): string => {
                  const today: Date = new Date();
                  return `${today.getFullYear().toString()}-${(today.getMonth() + 1).toString()}-${today.getDate().toString()}`;
              };
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 3 hrs to fix
              src/services/cartoDBService.ts on lines 83..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (area && area.rows && area.rows.length) {
                          const areaHa: any = area.rows && area.rows[0] || null;
                          result.area_ha = areaHa.area_ha;
                          result.value = [];
                          return result;
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 2 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 189..194
              src/services/cartoDBServiceV2.ts on lines 233..238

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 88.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                          if (area && area.rows && area.rows.length) {
                              const areaHa: any = area.rows && area.rows[0] || null;
                              result.area_ha = areaHa.area_ha;
                              result.value = [];
                              return result;
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 2 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 233..238
              src/services/cartoDBServiceV2.ts on lines 277..282

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 88.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (area && area.rows && area.rows.length) {
                          const areaHa: any = area.rows && area.rows[0] || null;
                          result.area_ha = areaHa.area_ha;
                          result.value = [];
                          return result;
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 2 hrs to fix
              src/services/cartoDBServiceV2.ts on lines 189..194
              src/services/cartoDBServiceV2.ts on lines 277..282

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 88.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          for (let i: number = 0, { length } = formats; i < length; i++) {
                              download[formats[i]] = `${this.apiUrl}?q=${queryFinal}&format=${formats[i]}`;
                          }
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 2 hrs to fix
              src/services/cartoDBService.ts on lines 121..123

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  constructor() {
                      this.client = new CartoDB.SQL({
                          user: config.get('cartoDB.user')
                      });
                      this.apiUrl = config.get('cartoDB.apiUrl');
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 1 other location - About 1 hr to fix
              src/services/cartoDBService.ts on lines 105..110

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      const area: Record<string, any> = await executeThunk(this.client, GIDAREA, {
                          table: 'gadm36_adm2',
                          level: '2',
                          gid: params.id2
                      });
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 45 mins to fix
              src/services/cartoDBServiceV2.ts on lines 184..188
              src/services/cartoDBServiceV2.ts on lines 228..232

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          const area: Record<string, any> = await executeThunk(this.client, GIDAREA, {
                              table: 'gadm36_countries',
                              level: '0',
                              gid: params.id0
                          });
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 45 mins to fix
              src/services/cartoDBServiceV2.ts on lines 228..232
              src/services/cartoDBServiceV2.ts on lines 272..276

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      const area: Record<string, any> = await executeThunk(this.client, GIDAREA, {
                          table: 'gadm36_adm1',
                          level: '1',
                          gid: params.id1
                      });
              Severity: Major
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 45 mins to fix
              src/services/cartoDBServiceV2.ts on lines 184..188
              src/services/cartoDBServiceV2.ts on lines 272..276

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      const params: Record<string, any> = {
                          useTable,
                          pid: id,
                          begin: periods[0],
                          end: periods[1]
              Severity: Minor
              Found in src/services/cartoDBServiceV2.ts and 2 other locations - About 35 mins to fix
              src/services/cartoDBService.ts on lines 170..175
              src/services/cartoDBService.ts on lines 210..215

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status