Sign upLogin

gfw-api/gfw-subscription-api

View on GitHub
Star

Showing 129 of 129 total issues

Consider simplifying this complex logical expression.
Open

                        if (result.data && result.data.length === 1 && result.data[0].value && result.data[0].value > 0) {
                            // getting metadata first
                            const metadata = await DatasetService.getMetadata(datasetQuery.id, subscription.application, subscription.language);
                            const areaName = subscription.params.area ? await DatasetService.getAreaName(subscription.params.area) : '';
                            const datasetName = metadata[0].attributes.info.name || dataset.attributes.name || dataset.name;
Severity: Major
Found in app/src/services/datasetService.js - About 40 mins to fix

    Function getTask has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    const getTask = async (task) => {
    logger.info(`[cronLoader] Publishing ${task.dataset}`);
    if (task.dataset === 'dataset') {
        redisClient.publish(CHANNEL, JSON.stringify({
            layer_slug: task.dataset
    Severity: Minor
    Found in app/src/cronLoader.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function subscriptionExists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    const subscriptionExists = (isForUser) => async (ctx, next) => {
    const { id } = ctx.params;

    if (!mongoose.Types.ObjectId.isValid(id)) {
        ctx.throw(400, 'ID is not valid');
    Severity: Minor
    Found in app/src/routes/api/v1/subscription.router.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        static async transform(results, layer, subscription, begin, end) {

        results.alert_count_degradation = 0;
        results.alert_count_deforestation = 0;
        if (results.value) {
    Severity: Minor
    Found in app/src/presenters/imazonPresenter.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getAllSubscriptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        static async getAllSubscriptions(
        link,
        application = undefined,
        env = undefined,
        page = 1,
    Severity: Minor
    Found in app/src/services/subscriptionService.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        transform() {
        const stories = [];
        if (this.results && this.results.length > 0) {
            for (let i = 0, { length } = this.results; i < length; i++) {
                stories.push({
    Severity: Minor
    Found in app/src/adapters/storyAdapter.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        'guira-loss': {
        layerSlug: 'guira-loss',
        alert_name: 'Brazil Alerts',
        selected_area: 'ISO Code: BRA',
        unsubscribe_url: 'http://www.globalforestwatch.org/unsubscribe_url',
    Severity: Minor
    Found in app/src/services/mockService.js and 2 other locations - About 35 mins to fix
    app/src/services/mockService.js on lines 142..151
    app/src/services/mockService.js on lines 152..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        'umd-loss-gain': {
        layerSlug: 'umd-loss-gain',
        alert_name: 'Brazil Alerts',
        selected_area: 'ISO Code: BRA',
        unsubscribe_url: 'http://www.globalforestwatch.org/unsubscribe_url',
    Severity: Minor
    Found in app/src/services/mockService.js and 2 other locations - About 35 mins to fix
    app/src/services/mockService.js on lines 132..141
    app/src/services/mockService.js on lines 152..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        'prodes-loss': {
        layerSlug: 'prodes-loss',
        alert_name: 'Brazil Alerts',
        selected_area: 'ISO Code: BRA',
        unsubscribe_url: 'http://www.globalforestwatch.org/unsubscribe_url',
    Severity: Minor
    Found in app/src/services/mockService.js and 2 other locations - About 35 mins to fix
    app/src/services/mockService.js on lines 132..141
    app/src/services/mockService.js on lines 142..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

            return null;
    Severity: Major
    Found in app/src/routes/api/v1/subscription.router.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return `/wdpa/${params.wdpaid}`;
      Severity: Major
      Found in app/src/services/analysisClassifier.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return null;
        Severity: Major
        Found in app/src/services/imageService.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return data.rows[0].bbox;
          Severity: Major
          Found in app/src/services/imageService.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return url;
            Severity: Major
            Found in app/src/services/analysisClassifier.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return null;
              Severity: Major
              Found in app/src/services/analysisService.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return null;
                Severity: Major
                Found in app/src/services/imageService.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return `/use/${params.use}/${params.useid}`;
                  Severity: Major
                  Found in app/src/services/analysisClassifier.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return GeostoreService.getGeostoreFromUseId(params.use, params.useid);
                    Severity: Major
                    Found in app/src/services/geostoreService.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return null;
                      Severity: Major
                      Found in app/src/services/imageService.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return GeostoreService.getGeostoreFromISOCountryCode(params.iso.country);
                        Severity: Major
                        Found in app/src/services/geostoreService.js - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language