Sign upLogin

gfw-api/glad-analysis-tiled

View on GitHub
Star
gladAnalysis/serializers.py

Summary

Maintainability
A
2 hrs
Test Coverage
F
13%

Function build_download_urls has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def build_download_urls(id_tuple, geostore_id, agg_values, agg_by, period, conf):
    # id_tuple looks like this: (iso, adm1, adm2)
    if id_tuple:

        # unpack it
Severity: Minor
Found in gladAnalysis/serializers.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_download_urls has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def build_download_urls(id_tuple, geostore_id, agg_values, agg_by, period, conf):
Severity: Minor
Found in gladAnalysis/serializers.py - About 45 mins to fix

    Function serialize_response has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def serialize_response(request, glad_alerts, aoi_area_ha, geostore_id=None, id_tuple=None):
    Severity: Minor
    Found in gladAnalysis/serializers.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status