Sign upLogin

giansalex/greenter-ws

View on GitHub
Star

Showing 12 of 12 total issues

Method processResponse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function processResponse(StatusResponse $status): StatusResult
    {
        $code = $status->getCodRespuesta();

        $result = new StatusResult();
Severity: Minor
Found in src/Api/GreSender.php - About 1 hr to fix

    Method processResponse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function processResponse($status): StatusResult
    {
        $originCode = $status->statusCode;
        $code = (int)$originCode;
    Severity: Minor
    Found in src/Ws/Services/ExtService.php - About 1 hr to fix

      Method getStatusResult has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function getStatusResult(string $method, string $resultName, string $ruc, string $tipo, string $serie, int $numero)
      Severity: Minor
      Found in src/Ws/Services/ConsultCdrService.php - About 45 mins to fix

        Function processResponse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function processResponse(StatusResponse $status): StatusResult
    {
        $code = $status->getCodRespuesta();

        $result = new StatusResult();
        Severity: Minor
        Found in src/Api/GreSender.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return '';
        Severity: Major
        Found in src/Ws/Reader/XmlFilenameExtractor.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return '';
          Severity: Major
          Found in src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return '40';
            Severity: Major
            Found in src/Ws/Reader/XmlFilenameExtractor.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return Retention::class;
              Severity: Major
              Found in src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->getFromVoidedDoc($doc);
                Severity: Major
                Found in src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return '20';
                  Severity: Major
                  Found in src/Ws/Reader/XmlFilenameExtractor.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return Summary::class;
                    Severity: Major
                    Found in src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

                      Function processResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function processResponse($status): StatusResult
    {
        $originCode = $status->statusCode;
        $code = (int)$originCode;
                      Severity: Minor
                      Found in src/Ws/Services/ExtService.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language