Sign upLogin

giedomak/Telepath

View on GitHub
Star
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    /**
     * Number of paths labeled l2 from nodes in middle to nodes in in.
     */
    fun two(edges: Pair<Edge, Edge>): Int {
        if (initAfterMath) afterMath()
Severity: Minor
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 1 other location - About 55 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 91..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    /**
     * Number of paths labeled l1 from nodes in out to nodes in middle.
     */
    fun one(edges: Pair<Edge, Edge>): Int {
        if (initAfterMath) afterMath()
Severity: Minor
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 1 other location - About 55 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 99..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    /**
     * Number of nodes in G which have incoming [edges].
     */
    fun `in`(edges: Pair<Edge, Edge>): Int {
        return syn2.inMap[edges]?.size ?: 0
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 2 other locations - About 50 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 49..56
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    /**
     * Number of pairs in G labeled by l1/l2.
     */
    fun pairs(edges: Pair<Edge, Edge>): Int {
        return syn2.pairsMap[edges]?.size ?: 0
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 2 other locations - About 50 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 42..47
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 49..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    /**
     * Number of nodes in G which have incoming edge labeled l1 and outgoing edge labeled l2.
     *
     * Where l1 is the first element of the [edges] pair, and l2 is the second element of the pair.
     */
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 2 other locations - About 50 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 42..47
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status