Sign upLogin

giedomak/Telepath

View on GitHub
Star
src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt

Summary

Maintainability
D
2 days
Test Coverage

Method runQuery has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private fun runQuery(key: String, value: String, results: MutableList<Pair<String, String>>, first: Boolean): MutableList<Pair<String, String>> {

        // Record the timings
        val physicalPlanTimings = mutableListOf<Long>()
        val evaluationTimings = mutableListOf<Long>()
Severity: Minor
Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt - About 1 hr to fix

    Method runCardinality has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private fun runCardinality(key: String, value: String) {


        // Retrieve input from the user until we retrieve 'END'
        val query = Query(Telepath, value)
    Severity: Minor
    Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun runLUBM(first: Boolean = true): List<Pair<String, String>> {

        val results = mutableListOf<Pair<String, String>>()

        for ((key, value) in LUBM) {
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt and 1 other location - About 2 hrs to fix
      src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt on lines 153..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun runAdvogato(first: Boolean = true): List<Pair<String, String>> {

        val results = mutableListOf<Pair<String, String>>()

        for ((key, value) in ADVOGATO) {
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt and 1 other location - About 2 hrs to fix
      src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt on lines 140..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun setupLUBM() {
        Telepath.pathIdentifierStore.clear()
        Node.clear()
        // Re-use the index we already constructed
        Telepath.kPathIndex = KPathIndexDisk(dir = kPathIndexLocationLUBM)
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt and 1 other location - About 2 hrs to fix
      src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt on lines 123..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 160.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun setupAdvogato() {
        Telepath.pathIdentifierStore.clear()
        Node.clear()
        // Re-use the index we already constructed
        Telepath.kPathIndex = KPathIndexDisk(dir = kPathIndexLocationAdvogato)
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt and 1 other location - About 2 hrs to fix
      src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt on lines 106..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 160.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun runLUBMCardinalityEstimation() {

        val yay = mutableListOf<Pair<String, Long>>()

        for ((key, value) in LUBM) {
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt and 1 other location - About 1 hr to fix
      src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt on lines 182..192

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun runAdvogatoCardinalityEstimation() {

        val yay = mutableListOf<Pair<String, Long>>()

        for ((key, value) in ADVOGATO) {
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt and 1 other location - About 1 hr to fix
      src/main/java/com/github/giedomak/telepath/utilities/Benchmark.kt on lines 194..204

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status