Sign upLogin

giedomak/Telepath

View on GitHub
Star
src/main/java/com/github/giedomak/telepath/utilities/CardinalityBenchmark.kt

Summary

Maintainability
C
7 hrs
Test Coverage

Method generate has a Cognitive Complexity of 52 (exceeds 20 allowed). Consider refactoring.
Open

    /**
     * Generate the cheapest physical plan for a given flattened logical plan.
     *
     * @param logicalPlan A flattened logical plan for which we have to generate the cheapest physical plan.
     * @return The cheapest physical plan for the given flattened logical plan.
Severity: Minor
Found in src/main/java/com/github/giedomak/telepath/utilities/CardinalityBenchmark.kt - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    /**
     * Generate the cheapest physical plan for a given flattened logical plan.
     *
     * @param logicalPlan A flattened logical plan for which we have to generate the cheapest physical plan.
     * @return The cheapest physical plan for the given flattened logical plan.
Severity: Minor
Found in src/main/java/com/github/giedomak/telepath/utilities/CardinalityBenchmark.kt - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            for (operator in LogicalPlan.OPERATORS) {

                            // Actually check for containment with the operator.
                            if (logicalPlan.containsSubtreesThroughOperator(subtree1, subtree2, operator)) {
    Severity: Major
    Found in src/main/java/com/github/giedomak/telepath/utilities/CardinalityBenchmark.kt - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status