Sign upLogin

gielfeldt/iterators

View on GitHub
Star
src/AtomicTempFileObjects.php

Summary

Maintainability
A
1 hr
Test Coverage

Missing class import via use statement (line '74', column '23').
Open

            throw new \RuntimeException("File: $fileName already opened!");
Severity: Minor
Found in src/AtomicTempFileObjects.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '89', column '23').
Open

            throw new \RuntimeException("File: " . $realPath . " already opened!");
Severity: Minor
Found in src/AtomicTempFileObjects.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '43', column '23').
Open

            throw new \RuntimeException("File: $fileName not opened!");
Severity: Minor
Found in src/AtomicTempFileObjects.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid assigning values to variables in if clauses and the like (line '110', column '21').
Open

    public function splitCsvFile(\Iterator $input, callable $callback)
    {
        $callback = \Closure::fromCallable($callback);
        $this->process(
            $input,
Severity: Minor
Found in src/AtomicTempFileObjects.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$rowNum'.
Open

            function ($row, $rowNum, $input, $output) use ($callback) {
Severity: Minor
Found in src/AtomicTempFileObjects.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function process(\Iterator $input, callable $callback)
    {
        $callback = \Closure::fromCallable($callback);
        $input->rewind();
        iterator_apply(
Severity: Major
Found in src/AtomicTempFileObjects.php and 1 other location - About 1 hr to fix
src/AtomicTempFileObject.php on lines 149..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status